[PR #44] [MERGED] Feature/core repository separation #42

New Issue

adam · 2025-12-30T01:29:47+01:00

adam commented

2025-12-30 01:29:47 +01:00

📋 Pull Request Information

Original PR: https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/44
Author: @melihaksoy
Created: 9/26/2019
Status: ✅ Merged
Merged: 9/26/2019
Merged by: @melihaksoy

Base: master ← Head: feature/core_repository_separation

📝 Commits (6)

dd099f7 Fixed wrong package name
97d5525 Updated package name
6ac6041 Ignoring not-used warning - this graph is included in main graph
448118b Separated repository from core
c356207 Removing adapter from recyclerView when view is destroyed to prevent leak
c4bb752 Updated new module graph

📊 Changes

22 files changed (+50 additions, -40 deletions)

View changed files

📝 app/build.gradle (+1 -0)
📝 app/src/main/kotlin/com/melih/rocketscience/di/AppModule.kt (+1 -1)
📝 core/build.gradle (+1 -3)
📝 docs/module_graph.png (+0 -0)
📝 features/detail/build.gradle (+2 -0)
📝 features/detail/src/main/kotlin/com/melih/detail/di/DetailContributor.kt (+1 -1)
📝 features/detail/src/main/kotlin/com/melih/detail/di/scopes/DetailFragmentScope.kt (+1 -1)
📝 features/detail/src/main/kotlin/com/melih/detail/di/scopes/DetailScope.kt (+1 -1)
📝 features/launches/build.gradle (+2 -0)
📝 features/launches/src/main/AndroidManifest.xml (+1 -1)
📝 features/launches/src/main/kotlin/com/melih/launches/di/LaunchesContributor.kt (+4 -4)
📝 features/launches/src/main/kotlin/com/melih/launches/di/modules/LaunchesFragmentModule.kt (+2 -2)
📝 features/launches/src/main/kotlin/com/melih/launches/di/scopes/LaunchesFragmentScope.kt (+1 -1)
📝 features/launches/src/main/kotlin/com/melih/launches/di/scopes/LaunchesScope.kt (+1 -1)
📝 features/launches/src/main/kotlin/com/melih/launches/ui/LaunchesFragment.kt (+10 -5)
📝 features/launches/src/main/kotlin/com/melih/launches/ui/adapters/LaunchesAdapter.kt (+2 -2)
📝 features/launches/src/main/kotlin/com/melih/launches/ui/paging/LaunchesPagingSource.kt (+1 -1)
📝 features/launches/src/main/kotlin/com/melih/launches/ui/paging/LaunchesPagingSourceFactory.kt (+1 -1)
📝 features/launches/src/main/kotlin/com/melih/launches/ui/vm/LaunchesViewModel.kt (+2 -2)
📝 features/launches/src/main/res/layout/fragment_launches.xml (+1 -1)

...and 2 more files

📄 Description

Fixes #40, #41 , #42 & #43.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/44 **Author:** [@melihaksoy](https://github.com/melihaksoy) **Created:** 9/26/2019 **Status:** ✅ Merged **Merged:** 9/26/2019 **Merged by:** [@melihaksoy](https://github.com/melihaksoy) **Base:** `master` ← **Head:** `feature/core_repository_separation` --- ### 📝 Commits (6) - [`dd099f7`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/dd099f758275f82fa57bb87127168230f3e06475) Fixed wrong package name - [`97d5525`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/97d552593793b69e3cb32da027cca6bca471f2d3) Updated package name - [`6ac6041`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/6ac604194482ba4942cb3a9d71897d297dc7a22c) Ignoring not-used warning - this graph is included in main graph - [`448118b`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/448118bd59b0988685a072433c377c844c10bc24) Separated repository from core - [`c356207`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/c35620708670552c535852a666dc4a60731a6fcc) Removing adapter from recyclerView when view is destroyed to prevent leak - [`c4bb752`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/c4bb752a2cb779cae4397c703cdadbe0af37f56c) Updated new module graph ### 📊 Changes **22 files changed** (+50 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle` (+1 -0) 📝 `app/src/main/kotlin/com/melih/rocketscience/di/AppModule.kt` (+1 -1) 📝 `core/build.gradle` (+1 -3) 📝 `docs/module_graph.png` (+0 -0) 📝 `features/detail/build.gradle` (+2 -0) 📝 `features/detail/src/main/kotlin/com/melih/detail/di/DetailContributor.kt` (+1 -1) 📝 `features/detail/src/main/kotlin/com/melih/detail/di/scopes/DetailFragmentScope.kt` (+1 -1) 📝 `features/detail/src/main/kotlin/com/melih/detail/di/scopes/DetailScope.kt` (+1 -1) 📝 `features/launches/build.gradle` (+2 -0) 📝 `features/launches/src/main/AndroidManifest.xml` (+1 -1) 📝 `features/launches/src/main/kotlin/com/melih/launches/di/LaunchesContributor.kt` (+4 -4) 📝 `features/launches/src/main/kotlin/com/melih/launches/di/modules/LaunchesFragmentModule.kt` (+2 -2) 📝 `features/launches/src/main/kotlin/com/melih/launches/di/scopes/LaunchesFragmentScope.kt` (+1 -1) 📝 `features/launches/src/main/kotlin/com/melih/launches/di/scopes/LaunchesScope.kt` (+1 -1) 📝 `features/launches/src/main/kotlin/com/melih/launches/ui/LaunchesFragment.kt` (+10 -5) 📝 `features/launches/src/main/kotlin/com/melih/launches/ui/adapters/LaunchesAdapter.kt` (+2 -2) 📝 `features/launches/src/main/kotlin/com/melih/launches/ui/paging/LaunchesPagingSource.kt` (+1 -1) 📝 `features/launches/src/main/kotlin/com/melih/launches/ui/paging/LaunchesPagingSourceFactory.kt` (+1 -1) 📝 `features/launches/src/main/kotlin/com/melih/launches/ui/vm/LaunchesViewModel.kt` (+2 -2) 📝 `features/launches/src/main/res/layout/fragment_launches.xml` (+1 -1) _...and 2 more files_ </details> ### 📄 Description Fixes #40, #41 , #42 & #43. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:29:47 +01:00

adam closed this issue

2025-12-30 01:29:47 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Android-Kotlin-Modulerized-CleanArchitecture#42