[PR #38] [MERGED] #34 Change use of deprecated NetworkInfo enhancement #41

New Issue

adam · 2025-12-30T01:29:46+01:00

adam commented

2025-12-30 01:29:46 +01:00

📋 Pull Request Information

Original PR: https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/38
Author: @victorvicari
Created: 9/13/2019
Status: ✅ Merged
Merged: 9/24/2019
Merged by: @melihaksoy

Base: master ← Head: change_use_of_deprecated_NetworkInfo

📝 Commits (3)

402bb99 replace NetworkInto with the ConnectivityManager. Since this network validation is being done at repository level, I've had to add the network dependency on it's own AndroidManifest.
0954301 moved network_state_permission from repository manifest to app's manifest.
6715aaf Merge branch 'master' into change_use_of_deprecated_NetworkInfo

📊 Changes

3 files changed (+8 additions, -3 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+1 -0)
📝 core/src/main/kotlin/com/melih/core/di/CoreModule.kt (+6 -2)
📝 repository/src/main/AndroidManifest.xml (+1 -1)

📄 Description

Replace NetworkInto with the ConnectivityManager. Since this network validation is being done at repository level, I've had to add the network dependency on it's own AndroidManifest.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/38 **Author:** [@victorvicari](https://github.com/victorvicari) **Created:** 9/13/2019 **Status:** ✅ Merged **Merged:** 9/24/2019 **Merged by:** [@melihaksoy](https://github.com/melihaksoy) **Base:** `master` ← **Head:** `change_use_of_deprecated_NetworkInfo` --- ### 📝 Commits (3) - [`402bb99`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/402bb994fe36a3f1ef19fdce6d93c07fc6ee0fa2) replace NetworkInto with the ConnectivityManager. Since this network validation is being done at repository level, I've had to add the network dependency on it's own AndroidManifest. - [`0954301`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/09543013942f021dea2f7a3140981985a548be60) moved network_state_permission from repository manifest to app's manifest. - [`6715aaf`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/6715aaf1954360bcbf78303c9d994b64b8aab2aa) Merge branch 'master' into change_use_of_deprecated_NetworkInfo ### 📊 Changes **3 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+1 -0) 📝 `core/src/main/kotlin/com/melih/core/di/CoreModule.kt` (+6 -2) 📝 `repository/src/main/AndroidManifest.xml` (+1 -1) </details> ### 📄 Description Replace `NetworkInto` with the `ConnectivityManager`. Since this network validation is being done at repository level, I've had to add the network dependency on it's own `AndroidManifest`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:29:46 +01:00

adam closed this issue

2025-12-30 01:29:46 +01:00

adam referenced this issue

2025-12-30 01:29:47 +01:00

[PR #44] [MERGED] Feature/core repository separation #42

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Android-Kotlin-Modulerized-CleanArchitecture#41