starred/Android-Kotlin-Modulerized-CleanArchitecture
1
0
Fork 0
mirror of https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture.git synced 2026-01-11 20:00:32 +01:00
Code Issues 8 Packages Projects Releases Wiki Activity

[PR #16] [MERGED] Milestones/ms1 #34

New Issue
Closed
opened 2025-12-30 01:29:44 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:29:44 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/16
Author: @melihaksoy
Created: 7/11/2019
Status: ✅ Merged
Merged: 7/26/2019
Merged by: @melihaksoy

Base: master ← Head: milestones/ms1

📝 Commits (10+)

  • 3ade68b Minor format fixes, removed code duplication, providing launch details from dagger successfully
  • 5063804 Moved activity contributors to corresponding modules. Closes #13
  • 9b2d46c Renamed feature list to launches
  • c38aa90 Removed forgotten semicolons
  • f0f1488 Version bumps and renames
  • 077fa68 Closes Search functionality (#17)
  • fe6d2e5 Implemented patterns instead of using source manager. Fixed a bug where submitList was not working
  • e783f05 Started documentation, added scopes for features. Closes #18
  • a571dee JaCoCo backup
  • 0435f8f Various fixes and refactors, ready to go for paging

📊 Changes

103 files changed (+4361 additions, -710 deletions)

View changed files

📝 .circleci/config.yml (+5 -1)
📝 .gitignore (+1 -0)
➕ .gradletasknamecache (+3130 -0)
📝 app/build.gradle (+1 -1)
📝 app/src/main/kotlin/com/melih/rocketscience/di/AppComponent.kt (+6 -1)
➖ app/src/main/kotlin/com/melih/rocketscience/di/AppModule.kt (+0 -26)
📝 build.gradle (+9 -3)
➕ core/jacoco.exec (+0 -0)
📝 core/src/main/kotlin/com/melih/core/base/lifecycle/BaseActivity.kt (+0 -2)
📝 core/src/main/kotlin/com/melih/core/base/lifecycle/BaseFragment.kt (+0 -2)
➕ core/src/main/kotlin/com/melih/core/base/paging/BasePagingDataSource.kt (+140 -0)
➕ core/src/main/kotlin/com/melih/core/base/paging/BasePagingFactory.kt (+42 -0)
📝 core/src/main/kotlin/com/melih/core/base/recycler/BasePagingListAdapter.kt (+6 -6)
➕ core/src/main/kotlin/com/melih/core/base/viewmodel/BasePagingViewModel.kt (+70 -0)
📝 core/src/main/kotlin/com/melih/core/base/viewmodel/BaseViewModel.kt (+19 -7)
📝 core/src/main/kotlin/com/melih/core/di/CoreComponent.kt (+3 -3)
📝 core/src/main/kotlin/com/melih/core/di/CoreModule.kt (+3 -10)
📝 core/src/main/kotlin/com/melih/core/extensions/UtilityExtension.kt (+21 -0)
📝 core/src/main/kotlin/com/melih/core/utils/SnackbarBehaviour.kt (+1 -0)
📝 core/src/test/kotlin/com/melih/core/BaseTestWithMainThread.kt (+7 -7)

...and 80 more files

📄 Description

Closes #11
Closes #13
Closes #17
Closes #18
Closes #19
Closes #6
Closes #3
Closes #12
Closes #15

Worked on #14, but will skip. It's not suitable at this time.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/16 **Author:** [@melihaksoy](https://github.com/melihaksoy) **Created:** 7/11/2019 **Status:** ✅ Merged **Merged:** 7/26/2019 **Merged by:** [@melihaksoy](https://github.com/melihaksoy) **Base:** `master` ← **Head:** `milestones/ms1` --- ### 📝 Commits (10+) - [`3ade68b`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/3ade68b777893b37c2b15d39b8794c24164ab23a) Minor format fixes, removed code duplication, providing launch details from dagger successfully - [`5063804`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/50638046fda6ba6e78300860470ae5c2f0534f54) Moved activity contributors to corresponding modules. Closes #13 - [`9b2d46c`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/9b2d46c51c975daaff614447b6fe02d536f47347) Renamed feature list to launches - [`c38aa90`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/c38aa9040e11090679e84a41f786b630eb253452) Removed forgotten semicolons - [`f0f1488`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/f0f1488a3250071aa280fdea83a9cd632f49b2a4) Version bumps and renames - [`077fa68`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/077fa68ccaea6a4567d4c20661d013edf13a4955) Closes #17 - [`fe6d2e5`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/fe6d2e5c7651769d074ec94e71b58401da02ecf3) Implemented patterns instead of using source manager. Fixed a bug where submitList was not working - [`e783f05`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/e783f05debb2ee189c5e1c7545da7a22ec61ab5d) Started documentation, added scopes for features. Closes #18 - [`a571dee`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/a571deeb1dc93b2f2804542553bc1b979cf5714c) JaCoCo backup - [`0435f8f`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/0435f8fe4fa632a6430898b035d789bad4aa0a2c) Various fixes and refactors, ready to go for paging ### 📊 Changes **103 files changed** (+4361 additions, -710 deletions) <details> <summary>View changed files</summary> 📝 `.circleci/config.yml` (+5 -1) 📝 `.gitignore` (+1 -0) ➕ `.gradletasknamecache` (+3130 -0) 📝 `app/build.gradle` (+1 -1) 📝 `app/src/main/kotlin/com/melih/rocketscience/di/AppComponent.kt` (+6 -1) ➖ `app/src/main/kotlin/com/melih/rocketscience/di/AppModule.kt` (+0 -26) 📝 `build.gradle` (+9 -3) ➕ `core/jacoco.exec` (+0 -0) 📝 `core/src/main/kotlin/com/melih/core/base/lifecycle/BaseActivity.kt` (+0 -2) 📝 `core/src/main/kotlin/com/melih/core/base/lifecycle/BaseFragment.kt` (+0 -2) ➕ `core/src/main/kotlin/com/melih/core/base/paging/BasePagingDataSource.kt` (+140 -0) ➕ `core/src/main/kotlin/com/melih/core/base/paging/BasePagingFactory.kt` (+42 -0) 📝 `core/src/main/kotlin/com/melih/core/base/recycler/BasePagingListAdapter.kt` (+6 -6) ➕ `core/src/main/kotlin/com/melih/core/base/viewmodel/BasePagingViewModel.kt` (+70 -0) 📝 `core/src/main/kotlin/com/melih/core/base/viewmodel/BaseViewModel.kt` (+19 -7) 📝 `core/src/main/kotlin/com/melih/core/di/CoreComponent.kt` (+3 -3) 📝 `core/src/main/kotlin/com/melih/core/di/CoreModule.kt` (+3 -10) 📝 `core/src/main/kotlin/com/melih/core/extensions/UtilityExtension.kt` (+21 -0) 📝 `core/src/main/kotlin/com/melih/core/utils/SnackbarBehaviour.kt` (+1 -0) 📝 `core/src/test/kotlin/com/melih/core/BaseTestWithMainThread.kt` (+7 -7) _...and 80 more files_ </details> ### 📄 Description Closes #11 Closes #13 Closes #17 Closes #18 Closes #19 Closes #6 Closes #3 Closes #12 Closes #15 Worked on #14, but will skip. It's not suitable at this time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:29:44 +01:00
adam closed this issue 2025-12-30 01:29:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
documentation
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Android-Kotlin-Modulerized-CleanArchitecture#34
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?