[PR #45] [MERGED] WIP: feature/abstractions #43

New Issue

2025-12-30T01:29:47+01:00

adam commented

2025-12-30 01:29:47 +01:00

📋 Pull Request Information

Original PR: https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/45
Author: @melihaksoy
Created: 10/3/2019
Status: ✅ Merged
Merged: 10/30/2019
Merged by: @melihaksoy

Base: master ← Head: feature/abstractions

📝 Commits (10+)

4fb5493 Abstraction layer backup
6d506d8 Removed DataEntity, was unnecessary for now
3cbfdfa Separated network, persistence, entities and interaction, closes #29
99f23b6 Renamed binding
de6a850 Removed build files, example tests
05ecf0a Fixed build files were not being ignored all around app
aee98db Updated CI ymls
89379c8 Small changes
24dbf65 Fixed legacy repository package names
e0154fc Fixed CQ findings

📊 Changes

103 files changed (+1097 additions, -920 deletions)

View changed files

📝 .circleci/config.yml (+52 -4)
📝 .github/workflows/android.yml (+27 -3)
📝 .gitignore (+1 -0)
📝 Gemfile.lock (+8 -8)
📝 abstractions/.gitignore (+0 -0)
➕ abstractions/build.gradle (+17 -0)
📝 abstractions/consumer-rules.pro (+0 -0)
➕ abstractions/proguard-rules.pro (+21 -0)
➕ abstractions/src/main/AndroidManifest.xml (+3 -0)
➕ abstractions/src/main/kotlin/com/melih/abstractions/data/ViewEntity.kt (+3 -0)
➕ abstractions/src/main/kotlin/com/melih/abstractions/deliverable/Reason.kt (+6 -0)
📝 abstractions/src/main/kotlin/com/melih/abstractions/deliverable/Result.kt (+7 -6)
➕ abstractions/src/main/kotlin/com/melih/abstractions/mapper/Mapper.kt (+8 -0)
📝 abstractions/src/test/kotlin/com/melih/abstractions/ResultTest.kt (+13 -5)
📝 app/build.gradle (+8 -3)
📝 app/proguard-rules.pro (+1 -4)
📝 build.gradle (+8 -6)
📝 core/build.gradle (+2 -2)
📝 core/src/main/kotlin/com/melih/core/base/lifecycle/BaseFragment.kt (+1 -1)
📝 core/src/main/kotlin/com/melih/core/base/paging/BasePagingDataSource.kt (+15 -11)

...and 80 more files

📄 Description

WIP

Closes #24
Closes #29

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/45 **Author:** [@melihaksoy](https://github.com/melihaksoy) **Created:** 10/3/2019 **Status:** ✅ Merged **Merged:** 10/30/2019 **Merged by:** [@melihaksoy](https://github.com/melihaksoy) **Base:** `master` ← **Head:** `feature/abstractions` --- ### 📝 Commits (10+) - [`4fb5493`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/4fb5493da22220e8b695236833fddc4606568c16) Abstraction layer backup - [`6d506d8`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/6d506d814c73798d690ad0ba7a25331ac0105678) Removed DataEntity, was unnecessary for now - [`3cbfdfa`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/3cbfdfae1cc3469fd9ffb91f7af29923a41d6301) Separated network, persistence, entities and interaction, closes #29 - [`99f23b6`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/99f23b6b3b4397bdc5abe53cff2524d290c3d91a) Renamed binding - [`de6a850`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/de6a85000a7d4e0f93cc8b57d8999640abb76ae3) Removed build files, example tests - [`05ecf0a`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/05ecf0a7db458c9b261fe11a83d97d96aaef9a8e) Fixed build files were not being ignored all around app - [`aee98db`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/aee98dba7192ec0243b643ec1b8f392486fb38d8) Updated CI ymls - [`89379c8`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/89379c8e9b76effb7bf2b42cd704a2a62ea9061a) Small changes - [`24dbf65`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/24dbf6589efbed124f1d3c7eab727cec44b8ddfb) Fixed legacy repository package names - [`e0154fc`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/e0154fc7b2c67d0e6e927572334e27b7ab8a5836) Fixed CQ findings ### 📊 Changes **103 files changed** (+1097 additions, -920 deletions) <details> <summary>View changed files</summary> 📝 `.circleci/config.yml` (+52 -4) 📝 `.github/workflows/android.yml` (+27 -3) 📝 `.gitignore` (+1 -0) 📝 `Gemfile.lock` (+8 -8) 📝 `abstractions/.gitignore` (+0 -0) ➕ `abstractions/build.gradle` (+17 -0) 📝 `abstractions/consumer-rules.pro` (+0 -0) ➕ `abstractions/proguard-rules.pro` (+21 -0) ➕ `abstractions/src/main/AndroidManifest.xml` (+3 -0) ➕ `abstractions/src/main/kotlin/com/melih/abstractions/data/ViewEntity.kt` (+3 -0) ➕ `abstractions/src/main/kotlin/com/melih/abstractions/deliverable/Reason.kt` (+6 -0) 📝 `abstractions/src/main/kotlin/com/melih/abstractions/deliverable/Result.kt` (+7 -6) ➕ `abstractions/src/main/kotlin/com/melih/abstractions/mapper/Mapper.kt` (+8 -0) 📝 `abstractions/src/test/kotlin/com/melih/abstractions/ResultTest.kt` (+13 -5) 📝 `app/build.gradle` (+8 -3) 📝 `app/proguard-rules.pro` (+1 -4) 📝 `build.gradle` (+8 -6) 📝 `core/build.gradle` (+2 -2) 📝 `core/src/main/kotlin/com/melih/core/base/lifecycle/BaseFragment.kt` (+1 -1) 📝 `core/src/main/kotlin/com/melih/core/base/paging/BasePagingDataSource.kt` (+15 -11) _...and 80 more files_ </details> ### 📄 Description WIP Closes #24 Closes #29 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:29:47 +01:00

adam closed this issue

2025-12-30 01:29:48 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Android-Kotlin-Modulerized-CleanArchitecture#43