starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-03-26 02:51:13 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Replace some usages of java.lang.String.replaceAll with String.replace (#701)

Browse Source 
Both methods replace all occurrences.
The difference is that String.replaceAll interprets its first argument as a regex.
This commit is contained in:
translatenix
2024-10-16 15:00:45 -07:00
committed by GitHub
parent 421711be10
commit 1022cf3ff3
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java
View File

@@ -1516,7 +1516,7 @@ public final class AstBuilder extends AbstractAstBuilder<Object> {
text = "-" + text;
}
text = text.replaceAll("_", "");
text = text.replace("_", "");
try {
var num = Long.parseLong(text, radix);
return new IntLiteralNode(section, num);
@@ -1550,7 +1550,7 @@ public final class AstBuilder extends AbstractAstBuilder<Object> {
source.createSection(ctx.getStart().getStartIndex() + exponentIdx + 1, 1));
}
text = text.replaceAll("_", "");
text = text.replace("_", "");
try {
var num = Double.parseDouble(text);
return new FloatLiteralNode(section, num);

4
pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java
View File

@@ -492,7 +492,7 @@ final class PackageResolvers {
Files.createDirectories(tmpDir);
var tmpPath =
Files.createTempFile(
tmpDir, IoUtils.encodePath(packageUri.toString().replaceAll("/", "-")), ".json");
tmpDir, IoUtils.encodePath(packageUri.toString().replace("/", "-")), ".json");
try {
downloadMetadata(packageUri, requestUri, tmpPath, checksums);
Files.createDirectories(cachePath.getParent());
@@ -544,7 +544,7 @@ final class PackageResolvers {
Files.createDirectories(tmpDir);
var tmpPath =
Files.createTempFile(
tmpDir, IoUtils.encodePath(packageUri.toString().replaceAll("/", "-")), ".zip");
tmpDir, IoUtils.encodePath(packageUri.toString().replace("/", "-")), ".zip");
try {
var checksumBytes =
downloadUriToPathAndComputeChecksum(dependencyMetadata.getPackageZipUrl(), tmpPath);