From 1022cf3ff32850ed9654e4fc0fb632b369b14330 Mon Sep 17 00:00:00 2001
From: translatenix <119817707+translatenix@users.noreply.github.com>
Date: Wed, 16 Oct 2024 15:00:45 -0700
Subject: [PATCH] Replace some usages of java.lang.String.replaceAll with
 String.replace (#701)

Both methods replace all occurrences.
The difference is that String.replaceAll interprets its first argument as a regex.
---
 .../src/main/java/org/pkl/core/ast/builder/AstBuilder.java    | 4 ++--
 .../src/main/java/org/pkl/core/packages/PackageResolvers.java | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java b/pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java
index a4acd001..0cf088c9 100644
--- a/pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java
+++ b/pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java
@@ -1516,7 +1516,7 @@ public final class AstBuilder extends AbstractAstBuilder<Object> {
       text = "-" + text;
     }
 
-    text = text.replaceAll("_", "");
+    text = text.replace("_", "");
     try {
       var num = Long.parseLong(text, radix);
       return new IntLiteralNode(section, num);
@@ -1550,7 +1550,7 @@ public final class AstBuilder extends AbstractAstBuilder<Object> {
           source.createSection(ctx.getStart().getStartIndex() + exponentIdx + 1, 1));
     }
 
-    text = text.replaceAll("_", "");
+    text = text.replace("_", "");
     try {
       var num = Double.parseDouble(text);
       return new FloatLiteralNode(section, num);
diff --git a/pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java b/pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java
index 797aa234..4472b50c 100644
--- a/pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java
+++ b/pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java
@@ -492,7 +492,7 @@ final class PackageResolvers {
       Files.createDirectories(tmpDir);
       var tmpPath =
           Files.createTempFile(
-              tmpDir, IoUtils.encodePath(packageUri.toString().replaceAll("/", "-")), ".json");
+              tmpDir, IoUtils.encodePath(packageUri.toString().replace("/", "-")), ".json");
       try {
         downloadMetadata(packageUri, requestUri, tmpPath, checksums);
         Files.createDirectories(cachePath.getParent());
@@ -544,7 +544,7 @@ final class PackageResolvers {
       Files.createDirectories(tmpDir);
       var tmpPath =
           Files.createTempFile(
-              tmpDir, IoUtils.encodePath(packageUri.toString().replaceAll("/", "-")), ".zip");
+              tmpDir, IoUtils.encodePath(packageUri.toString().replace("/", "-")), ".zip");
       try {
         var checksumBytes =
             downloadUriToPathAndComputeChecksum(dependencyMetadata.getPackageZipUrl(), tmpPath);