[PR #10834] [MERGED] Closes #10545: Standardize description & comment fields on primary models #13705

New Issue

adam · 2025-12-29T23:20:21+01:00

adam commented

2025-12-29 23:20:21 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/10834
Author: @jeremystretch
Created: 11/3/2022
Status: ✅ Merged
Merged: 11/4/2022
Merged by: @jeremystretch

Base: feature ← Head: 10545-descriptions-comments

📝 Commits (5)

faf485d Standardize description & comments fields on primary models
3eb68c7 Update REST API serializers
2235b9a Update forms
ecbea70 Update tables
ac96596 Update templates

📊 Changes

105 files changed (+1014 additions, -534 deletions)

View changed files

📝 docs/release-notes/version-3.4.md (+51 -0)
📝 netbox/circuits/api/serializers.py (+2 -2)
📝 netbox/circuits/forms/bulk_edit.py (+5 -1)
📝 netbox/circuits/forms/bulk_import.py (+1 -1)
📝 netbox/circuits/forms/model_forms.py (+4 -5)
➕ netbox/circuits/migrations/0041_standardize_description_comments.py (+18 -0)
📝 netbox/circuits/models/circuits.py (+2 -9)
📝 netbox/circuits/models/providers.py (+3 -14)
📝 netbox/circuits/tables/providers.py (+2 -2)
📝 netbox/dcim/api/serializers.py (+20 -21)
📝 netbox/dcim/forms/bulk_edit.py (+102 -29)
📝 netbox/dcim/forms/bulk_import.py (+9 -8)
📝 netbox/dcim/forms/model_forms.py (+22 -18)
📝 netbox/dcim/forms/object_import.py (+2 -2)
➕ netbox/dcim/migrations/0165_standardize_description_comments.py (+78 -0)
📝 netbox/dcim/models/cables.py (+3 -3)
📝 netbox/dcim/models/devices.py (+6 -18)
📝 netbox/dcim/models/power.py (+3 -7)
📝 netbox/dcim/models/racks.py (+3 -6)
📝 netbox/dcim/models/sites.py (+2 -9)

...and 80 more files

📄 Description

Fixes: #10545

Introduce PrimaryModel abstract class to standardize description and comments fields for all primary models
Generate database migrations
Extend REST API serializers
Update all model, import, and bulk edit forms
Add the necessary table columns
Update templates

(I realize this looks like a ton of change, but it's almost entirely boilerplate.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/10834 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 11/3/2022 **Status:** ✅ Merged **Merged:** 11/4/2022 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `10545-descriptions-comments` --- ### 📝 Commits (5) - [`faf485d`](https://github.com/netbox-community/netbox/commit/faf485d4d4fcdce2fb4e645896782f29572d2875) Standardize description & comments fields on primary models - [`3eb68c7`](https://github.com/netbox-community/netbox/commit/3eb68c76c4999a6f9d9c9d5efef00e3e487c9dd9) Update REST API serializers - [`2235b9a`](https://github.com/netbox-community/netbox/commit/2235b9a694c6afb6260c36c88e1e777efa165405) Update forms - [`ecbea70`](https://github.com/netbox-community/netbox/commit/ecbea7057b28c01e4511cf9e21b9674b64cb7839) Update tables - [`ac96596`](https://github.com/netbox-community/netbox/commit/ac965964e80003340c2e406a5e266cba32dc00f6) Update templates ### 📊 Changes **105 files changed** (+1014 additions, -534 deletions) <details> <summary>View changed files</summary> 📝 `docs/release-notes/version-3.4.md` (+51 -0) 📝 `netbox/circuits/api/serializers.py` (+2 -2) 📝 `netbox/circuits/forms/bulk_edit.py` (+5 -1) 📝 `netbox/circuits/forms/bulk_import.py` (+1 -1) 📝 `netbox/circuits/forms/model_forms.py` (+4 -5) ➕ `netbox/circuits/migrations/0041_standardize_description_comments.py` (+18 -0) 📝 `netbox/circuits/models/circuits.py` (+2 -9) 📝 `netbox/circuits/models/providers.py` (+3 -14) 📝 `netbox/circuits/tables/providers.py` (+2 -2) 📝 `netbox/dcim/api/serializers.py` (+20 -21) 📝 `netbox/dcim/forms/bulk_edit.py` (+102 -29) 📝 `netbox/dcim/forms/bulk_import.py` (+9 -8) 📝 `netbox/dcim/forms/model_forms.py` (+22 -18) 📝 `netbox/dcim/forms/object_import.py` (+2 -2) ➕ `netbox/dcim/migrations/0165_standardize_description_comments.py` (+78 -0) 📝 `netbox/dcim/models/cables.py` (+3 -3) 📝 `netbox/dcim/models/devices.py` (+6 -18) 📝 `netbox/dcim/models/power.py` (+3 -7) 📝 `netbox/dcim/models/racks.py` (+3 -6) 📝 `netbox/dcim/models/sites.py` (+2 -9) _...and 80 more files_ </details> ### 📄 Description ### Fixes: #10545 - Introduce `PrimaryModel` abstract class to standardize `description` and `comments` fields for all primary models - Generate database migrations - Extend REST API serializers - Update all model, import, and bulk edit forms - Add the necessary table columns - Update templates (I realize this looks like a _ton_ of change, but it's almost entirely boilerplate.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 23:20:21 +01:00

adam closed this issue

2025-12-29 23:20:21 +01:00

adam referenced this issue

2025-12-29 23:23:22 +01:00

[PR #13705] [MERGED] Release v3.6.1 #14243

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#13705