starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #5308] [MERGED] Fixes #5271: Extend DynamicModelChoiceMixin to accept initial field values implied by child fields #13004

New Issue
Closed
opened 2025-12-29 22:24:51 +01:00 by adam · 0 comments
adam commented 2025-12-29 22:24:51 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/5308
Author: @jeremystretch
Created: 11/4/2020
Status: ✅ Merged
Merged: 11/4/2020
Merged by: @jeremystretch

Base: develop ← Head: 5271-DynamicModelChoiceMixin-initial

📝 Commits (3)

  • 1f0b1dd Add initial_params to DynamicModelChoiceMixin
  • 7598b89 Add initial_params to all forms
  • 798220c Fix filter reference

📊 Changes

6 files changed (+52 additions, -85 deletions)

View changed files

📝 netbox/dcim/forms.py (+19 -33)
📝 netbox/dcim/tests/test_forms.py (+0 -17)
📝 netbox/ipam/forms.py (+11 -12)
📝 netbox/tenancy/forms.py (+4 -12)
📝 netbox/utilities/forms/fields.py (+14 -2)
📝 netbox/virtualization/forms.py (+4 -9)

📄 Description

Fixes: #5271

  • Adds the initial_params kwarg to DynamicModelChoiceMixin, which allows a field to infer its default initial value from the initial value of a child field
  • Set initial_params on all appropriate instances and remove relevant logic from __init__()

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/5308 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 11/4/2020 **Status:** ✅ Merged **Merged:** 11/4/2020 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `5271-DynamicModelChoiceMixin-initial` --- ### 📝 Commits (3) - [`1f0b1dd`](https://github.com/netbox-community/netbox/commit/1f0b1dd10e5eeb643ebc6a56aaefe8f2821a405b) Add initial_params to DynamicModelChoiceMixin - [`7598b89`](https://github.com/netbox-community/netbox/commit/7598b891c1e356a0df77850b50877f9340e235d3) Add initial_params to all forms - [`798220c`](https://github.com/netbox-community/netbox/commit/798220cf9a7e9de7a3b859e762e122aaa457749e) Fix filter reference ### 📊 Changes **6 files changed** (+52 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms.py` (+19 -33) 📝 `netbox/dcim/tests/test_forms.py` (+0 -17) 📝 `netbox/ipam/forms.py` (+11 -12) 📝 `netbox/tenancy/forms.py` (+4 -12) 📝 `netbox/utilities/forms/fields.py` (+14 -2) 📝 `netbox/virtualization/forms.py` (+4 -9) </details> ### 📄 Description ### Fixes: #5271 - Adds the `initial_params` kwarg to DynamicModelChoiceMixin, which allows a field to infer its default initial value from the initial value of a child field - Set `initial_params` on all appropriate instances and remove relevant logic from `__init__()` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 22:24:51 +01:00
adam closed this issue 2025-12-29 22:24:51 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#13004
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?