starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1060] [MERGED] feat(wm): apply workspace-rules to floating windows #1184

New Issue
Closed
opened 2026-01-05 14:54:23 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:23 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1060
Author: @alex-ds13
Created: 10/16/2024
Status: ✅ Merged
Merged: 10/18/2024
Merged by: @LGUG2Z

Base: master ← Head: feature/workspace-rules-for-floating-windows

📝 Commits (1)

  • 9f93ea0 feat(wm): apply workspace-rules to floating windows

📊 Changes

3 files changed (+73 additions, -13 deletions)

View changed files

📝 komorebi/src/process_event.rs (+1 -1)
📝 komorebi/src/window_manager.rs (+42 -4)
📝 komorebi/src/workspace.rs (+30 -8)

📄 Description

This commit allows workspace-rules and initial_workspace_rules to be applied to floating windows. As a by product of this commit, now the command to show visible-windows will now also show the maximized windows, monocled windows and floating windows.

Should fix the issue #990

@LGUG2Z I know you wanted to handle the refactor of the visible-windows type of functions but since this one was needed for this PR I've already changed it...

There are two TODO comments I added on this commit that I would like to have your feedback on.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1060 **Author:** [@alex-ds13](https://github.com/alex-ds13) **Created:** 10/16/2024 **Status:** ✅ Merged **Merged:** 10/18/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `feature/workspace-rules-for-floating-windows` --- ### 📝 Commits (1) - [`9f93ea0`](https://github.com/LGUG2Z/komorebi/commit/9f93ea0ee80681405d81a99a0aa81ad82bd174e9) feat(wm): apply workspace-rules to floating windows ### 📊 Changes **3 files changed** (+73 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/process_event.rs` (+1 -1) 📝 `komorebi/src/window_manager.rs` (+42 -4) 📝 `komorebi/src/workspace.rs` (+30 -8) </details> ### 📄 Description This commit allows `workspace-rules` and `initial_workspace_rules` to be applied to floating windows. As a by product of this commit, now the command to show `visible-windows` will now also show the maximized windows, monocled windows and floating windows. Should fix the issue #990 @LGUG2Z I know you wanted to handle the refactor of the `visible-windows` type of functions but since this one was needed for this PR I've already changed it... There are two `TODO` comments I added on this commit that I would like to have your feedback on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:23 +01:00
adam closed this issue 2026-01-05 14:54:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1184
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?