starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #1184] [MERGED] feat(bar): scaled icon size relying on the font size #1242

New Issue
Closed
opened 2026-01-05 14:54:35 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:54:35 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/1184
Author: @CtByte
Created: 12/17/2024
Status: ✅ Merged
Merged: 12/17/2024
Merged by: @LGUG2Z

Base: master ← Head: bar_icon_size

📝 Commits (1)

  • 80fdb8d feat(bar): scaled icon size relying on the font size

📊 Changes

13 files changed (+124 additions, -134 deletions)

View changed files

📝 komorebi-bar/src/bar.rs (+6 -6)
📝 komorebi-bar/src/battery.rs (+8 -11)
📝 komorebi-bar/src/cpu.rs (+8 -11)
📝 komorebi-bar/src/date.rs (+8 -11)
📝 komorebi-bar/src/komorebi.rs (+4 -12)
📝 komorebi-bar/src/komorebi_layout.rs (+1 -8)
📝 komorebi-bar/src/media.rs (+8 -11)
📝 komorebi-bar/src/memory.rs (+8 -11)
📝 komorebi-bar/src/network.rs (+29 -25)
📝 komorebi-bar/src/render.rs (+26 -5)
📝 komorebi-bar/src/selected_frame.rs (+2 -1)
📝 komorebi-bar/src/storage.rs (+8 -11)
📝 komorebi-bar/src/time.rs (+8 -11)

📄 Description

This commit changes the way icons are displayed on the bar. There was an issue with how app icons were sized using shrink_to_fit. This has been changed to use fit_to_exact_size instead, relying on the font size as a starting point and scaling it to 1.4 of its size, making the icons to appear larger.

The same scaling was done to all the widget icons as well to make them look unified.

https://github.com/user-attachments/assets/bae030d4-d444-4f43-b7a9-e860d5a31583

Special thanks to @alex-ds13 for initiating this change. It would be most appreciated if this PR is merged before his

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/1184 **Author:** [@CtByte](https://github.com/CtByte) **Created:** 12/17/2024 **Status:** ✅ Merged **Merged:** 12/17/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `bar_icon_size` --- ### 📝 Commits (1) - [`80fdb8d`](https://github.com/LGUG2Z/komorebi/commit/80fdb8d84f1ac80d9426d8c3e155d068e74f709b) feat(bar): scaled icon size relying on the font size ### 📊 Changes **13 files changed** (+124 additions, -134 deletions) <details> <summary>View changed files</summary> 📝 `komorebi-bar/src/bar.rs` (+6 -6) 📝 `komorebi-bar/src/battery.rs` (+8 -11) 📝 `komorebi-bar/src/cpu.rs` (+8 -11) 📝 `komorebi-bar/src/date.rs` (+8 -11) 📝 `komorebi-bar/src/komorebi.rs` (+4 -12) 📝 `komorebi-bar/src/komorebi_layout.rs` (+1 -8) 📝 `komorebi-bar/src/media.rs` (+8 -11) 📝 `komorebi-bar/src/memory.rs` (+8 -11) 📝 `komorebi-bar/src/network.rs` (+29 -25) 📝 `komorebi-bar/src/render.rs` (+26 -5) 📝 `komorebi-bar/src/selected_frame.rs` (+2 -1) 📝 `komorebi-bar/src/storage.rs` (+8 -11) 📝 `komorebi-bar/src/time.rs` (+8 -11) </details> ### 📄 Description This commit changes the way icons are displayed on the bar. There was an issue with how app icons were sized using `shrink_to_fit`. This has been changed to use `fit_to_exact_size` instead, relying on the font size as a starting point and scaling it to `1.4` of its size, making the icons to appear larger. The same scaling was done to all the widget icons as well to make them look unified. https://github.com/user-attachments/assets/bae030d4-d444-4f43-b7a9-e860d5a31583 Special thanks to @alex-ds13 for initiating this change. It would be most appreciated if this PR is merged before [his](https://github.com/LGUG2Z/komorebi/pull/1177) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:54:35 +01:00
adam closed this issue 2026-01-05 14:54:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1242
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?