starred/komorebi
1
0
Fork 0
mirror of https://github.com/LGUG2Z/komorebi.git synced 2026-01-11 14:40:25 +01:00
Code Issues 87 Packages Projects Releases 10 Wiki Activity

[PR #694] [MERGED] fix(wm): adds special case for grid stacks to the right #1060

New Issue
Closed
opened 2026-01-05 14:53:57 +01:00 by adam · 0 comments
adam commented 2026-01-05 14:53:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/LGUG2Z/komorebi/pull/694
Author: @javierportillo
Created: 3/1/2024
Status: ✅ Merged
Merged: 3/2/2024
Merged by: @LGUG2Z

Base: master ← Head: fix/wrong-stack-behaviour-grid

📝 Commits (1)

  • c5c4651 fix(wm): adds special case for grid stacks to the right

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 komorebi/src/window_manager.rs (+3 -1)

📄 Description

The default stacking behaviour for all layouts was to subtract 1 to the calculated index for movements to the right or down, basically, for any movement where the new index is greater than the current one. This was not working correctly for the Grid layout.

This PR adds a special case that prevents the adjustment to the target container index so it behaves correctly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/LGUG2Z/komorebi/pull/694 **Author:** [@javierportillo](https://github.com/javierportillo) **Created:** 3/1/2024 **Status:** ✅ Merged **Merged:** 3/2/2024 **Merged by:** [@LGUG2Z](https://github.com/LGUG2Z) **Base:** `master` ← **Head:** `fix/wrong-stack-behaviour-grid` --- ### 📝 Commits (1) - [`c5c4651`](https://github.com/LGUG2Z/komorebi/commit/c5c465116d74cf82c068670f3987859fa00c0581) fix(wm): adds special case for grid stacks to the right ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `komorebi/src/window_manager.rs` (+3 -1) </details> ### 📄 Description The default stacking behaviour for all layouts was to subtract 1 to the calculated index for movements to the right or down, basically, for any movement where the new index is greater than the current one. This was not working correctly for the Grid layout. This PR adds a special case that prevents the adjustment to the target container index so it behaves correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-01-05 14:53:57 +01:00
adam closed this issue 2026-01-05 14:53:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
0.1.36
apps-behaving-badly
bug
bug
cannot-reproduce
documentation
enhancement
github_actions
i-am-stuck
i-will-definitely-work-on-this
i-will-not-work-on-this
i-will-probably-work-on-this
komorebi
komorebi-bar
komorebic
performance
pull-request
Mirrored from GitHub Pull Request
 translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/komorebi#1060
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?