fix(wm): avoid display notification spam

Looks like macOS spams every single possible CGDisplayChangeSummaryFlag
whenever a display is added or removed, which ends up with a lot of
calls to the monitor reconciliator and a lot of locks on the wm state.

To better handle the spam this commit ensures we only send monitor
reconciliation notifications on the DesktopShapeChanged, Add and Remove
flags.
This commit is contained in:
LGUG2Z committed 2025-09-27 09:22:34 -07:00
1 parent 6a194f7e6c
commit 69909df2f5
1 file changed
+21 -21
@@ -32,27 +32,27 @@ unsafe extern "C-unwind" fn callback(
));
}
if flags.contains(CGDisplayChangeSummaryFlags::EnabledFlag) {
tracing::debug!("display: {display_id} enabled");
monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange(
display_id,
));
}
if flags.contains(CGDisplayChangeSummaryFlags::DisabledFlag) {
tracing::debug!("display: {display_id} disabled");
monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange(
display_id,
));
}
if flags.contains(CGDisplayChangeSummaryFlags::MovedFlag) {
tracing::debug!("display: {display_id} moved");
monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange(
display_id,
));
}
// if flags.contains(CGDisplayChangeSummaryFlags::EnabledFlag) {
// tracing::debug!("display: {display_id} enabled");
// monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange(
// display_id,
// ));
// }
//
// if flags.contains(CGDisplayChangeSummaryFlags::DisabledFlag) {
// tracing::debug!("display: {display_id} disabled");
// monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange(
// display_id,
// ));
// }
//
// if flags.contains(CGDisplayChangeSummaryFlags::MovedFlag) {
// tracing::debug!("display: {display_id} moved");
// monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange(
// display_id,
// ));
// }
//
// if flags.contains(CGDisplayChangeSummaryFlags::BeginConfigurationFlag) {
// tracing::debug!("display: {display_id} configured");
// }