From 69909df2f59a5712cec492df0f18a972ac7b6a96 Mon Sep 17 00:00:00 2001 From: LGUG2Z Date: Sat, 27 Sep 2025 09:22:32 -0700 Subject: [PATCH] fix(wm): avoid display notification spam Looks like macOS spams every single possible CGDisplayChangeSummaryFlag whenever a display is added or removed, which ends up with a lot of calls to the monitor reconciliator and a lot of locks on the wm state. To better handle the spam this commit ensures we only send monitor reconciliation notifications on the DesktopShapeChanged, Add and Remove flags. --- .../src/display_reconfiguration_listener.rs | 42 +++++++++---------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/komorebi/src/display_reconfiguration_listener.rs b/komorebi/src/display_reconfiguration_listener.rs index 0056d3a5..acf1f042 100644 --- a/komorebi/src/display_reconfiguration_listener.rs +++ b/komorebi/src/display_reconfiguration_listener.rs @@ -32,27 +32,27 @@ unsafe extern "C-unwind" fn callback( )); } - if flags.contains(CGDisplayChangeSummaryFlags::EnabledFlag) { - tracing::debug!("display: {display_id} enabled"); - monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange( - display_id, - )); - } - - if flags.contains(CGDisplayChangeSummaryFlags::DisabledFlag) { - tracing::debug!("display: {display_id} disabled"); - monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange( - display_id, - )); - } - - if flags.contains(CGDisplayChangeSummaryFlags::MovedFlag) { - tracing::debug!("display: {display_id} moved"); - monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange( - display_id, - )); - } - + // if flags.contains(CGDisplayChangeSummaryFlags::EnabledFlag) { + // tracing::debug!("display: {display_id} enabled"); + // monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange( + // display_id, + // )); + // } + // + // if flags.contains(CGDisplayChangeSummaryFlags::DisabledFlag) { + // tracing::debug!("display: {display_id} disabled"); + // monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange( + // display_id, + // )); + // } + // + // if flags.contains(CGDisplayChangeSummaryFlags::MovedFlag) { + // tracing::debug!("display: {display_id} moved"); + // monitor_reconciliator::send_notification(MonitorNotification::DisplayConnectionChange( + // display_id, + // )); + // } + // // if flags.contains(CGDisplayChangeSummaryFlags::BeginConfigurationFlag) { // tracing::debug!("display: {display_id} configured"); // }