mirror of
https://github.com/LGUG2Z/komorebi.git
synced 2026-11-18 14:48:34 +01:00
feat(e2e): no known failure of maximizing.user once kfw has the fix
This commit is contained in:
1 parent
7f6e530b35
commit
0aec364345
2 files changed
+25
-9
No files matched your search
@@ -80,15 +80,10 @@ KNOWN_STEPS = {
|
||||
|
||||
|
||||
# the commit of komorebi's `next` that fixed what a step is known to fail, and
|
||||
# what it still fails on a build that has it: the marker is the first reason
|
||||
# before it and the second after it
|
||||
# what it still fails on a build that has it (None: nothing): the marker is the
|
||||
# first reason before it and the second after it
|
||||
KNOWN_STEPS_FIXED_BY = {
|
||||
"maximizing.user": (
|
||||
"3fa3d429",
|
||||
"kfw tracks a user's maximize and toggle-float ends it, but "
|
||||
"toggle-monocle is not ignored while a window is maximized (kfw "
|
||||
"enters the monocle and the window stays maximized)",
|
||||
),
|
||||
"maximizing.user": ("3fa3d429", None),
|
||||
}
|
||||
|
||||
|
||||
|
||||
@@ -340,9 +340,30 @@ def test_a_known_step_has_the_narrower_marker_on_a_commit_that_has_the_fix(
|
||||
|
||||
user.__module__ = "komorebi_vm.core.scenarios.maximizing"
|
||||
monkeypatch.setattr(run, "_contains", lambda fix, repo=None: True)
|
||||
monkeypatch.setitem(
|
||||
run.KNOWN_STEPS_FIXED_BY, "maximizing.user", ("fix", "a narrower one")
|
||||
)
|
||||
checks = run.RecordedChecks()
|
||||
|
||||
run._suite(checks, shared(user, checks))
|
||||
|
||||
assert checks.failed == 0
|
||||
assert "toggle-float" in checks.known[0]
|
||||
assert "a narrower one" in checks.known[0]
|
||||
|
||||
|
||||
def test_a_known_step_with_no_marker_after_the_fix_fails_as_it_did(
|
||||
monkeypatch: pytest.MonkeyPatch,
|
||||
) -> None:
|
||||
from komorebi_vm.core.suite import shared
|
||||
|
||||
def user(checks: run.RecordedChecks) -> None:
|
||||
checks.check("b", False)
|
||||
|
||||
user.__module__ = "komorebi_vm.core.scenarios.maximizing"
|
||||
monkeypatch.setattr(run, "_contains", lambda fix, repo=None: True)
|
||||
checks = run.RecordedChecks()
|
||||
|
||||
run._suite(checks, shared(user, checks))
|
||||
|
||||
assert checks.failed == 1
|
||||
assert checks.known == []
|
||||
Reference in new issue
Block a user