diff --git a/e2e/platforms/qemu_windows/run.py b/e2e/platforms/qemu_windows/run.py index c9328f53..c5b60f18 100644 --- a/e2e/platforms/qemu_windows/run.py +++ b/e2e/platforms/qemu_windows/run.py @@ -80,15 +80,10 @@ KNOWN_STEPS = { # the commit of komorebi's `next` that fixed what a step is known to fail, and -# what it still fails on a build that has it: the marker is the first reason -# before it and the second after it +# what it still fails on a build that has it (None: nothing): the marker is the +# first reason before it and the second after it KNOWN_STEPS_FIXED_BY = { - "maximizing.user": ( - "3fa3d429", - "kfw tracks a user's maximize and toggle-float ends it, but " - "toggle-monocle is not ignored while a window is maximized (kfw " - "enters the monocle and the window stays maximized)", - ), + "maximizing.user": ("3fa3d429", None), } diff --git a/e2e/platforms/qemu_windows/tests/test_runner.py b/e2e/platforms/qemu_windows/tests/test_runner.py index a09a94ca..e8321555 100644 --- a/e2e/platforms/qemu_windows/tests/test_runner.py +++ b/e2e/platforms/qemu_windows/tests/test_runner.py @@ -340,9 +340,30 @@ def test_a_known_step_has_the_narrower_marker_on_a_commit_that_has_the_fix( user.__module__ = "komorebi_vm.core.scenarios.maximizing" monkeypatch.setattr(run, "_contains", lambda fix, repo=None: True) + monkeypatch.setitem( + run.KNOWN_STEPS_FIXED_BY, "maximizing.user", ("fix", "a narrower one") + ) checks = run.RecordedChecks() run._suite(checks, shared(user, checks)) assert checks.failed == 0 - assert "toggle-float" in checks.known[0] + assert "a narrower one" in checks.known[0] + + +def test_a_known_step_with_no_marker_after_the_fix_fails_as_it_did( + monkeypatch: pytest.MonkeyPatch, +) -> None: + from komorebi_vm.core.suite import shared + + def user(checks: run.RecordedChecks) -> None: + checks.check("b", False) + + user.__module__ = "komorebi_vm.core.scenarios.maximizing" + monkeypatch.setattr(run, "_contains", lambda fix, repo=None: True) + checks = run.RecordedChecks() + + run._suite(checks, shared(user, checks)) + + assert checks.failed == 1 + assert checks.known == []