starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[Bug] Updating of existing channel leads to unexpected removing of ephemeral nodes #1069

New Issue
Closed
opened 2025-12-29 02:28:06 +01:00 by adam · 2 comments
adam commented 2025-12-29 02:28:06 +01:00
Owner
Copy Link

Originally created by @vaskravchuk on GitHub (Jul 19, 2025).

in case of replacing streaming session:
7fce5065c4/hscontrol/poll.go (L239C4-L242C5)
defer function will be called which will put node to ephemeral GC
7fce5065c4/hscontrol/poll.go (L196)
unexpected node deletion from DB happens which can lead to the issue like #2697

Originally created by @vaskravchuk on GitHub (Jul 19, 2025). in case of replacing streaming session: https://github.com/juanfont/headscale/blob/7fce5065c45dc233240bd334d12999bbd7c50488/hscontrol/poll.go#L239C4-L242C5 defer function will be called which will put node to ephemeral GC https://github.com/juanfont/headscale/blob/7fce5065c45dc233240bd334d12999bbd7c50488/hscontrol/poll.go#L196 unexpected node deletion from DB happens which can lead to the issue like #2697
adam closed this issue 2025-12-29 02:28:06 +01:00
adam commented 2025-12-29 02:28:07 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Sep 9, 2025):

Good find! Will have a look at this tomorrow.

@kradalby commented on GitHub (Sep 9, 2025): Good find! Will have a look at this tomorrow.
adam commented 2025-12-29 02:28:07 +01:00
Author
Owner
Copy Link

@kradalby commented on GitHub (Sep 10, 2025):

This got moved around and should not happen after #2670

@kradalby commented on GitHub (Sep 10, 2025): This got moved around and should not happen after #2670
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1069
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?