starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-11 20:00:28 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1069] [CLOSED] ACL testing playground #1855

New Issue
Closed
opened 2025-12-29 02:31:59 +01:00 by adam · 0 comments
adam commented 2025-12-29 02:31:59 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1069
Author: @kradalby
Created: 12/15/2022
Status: ❌ Closed

Base: main ← Head: integration-acl-init

📄 Description

This PR contains integration tests for ACLs, most of them will likely fail as they are not correctly implemented in Headscale and I suspect this will be the way forward:

If a test passes its picked out and submitted as a PR that we can have now.

if a test fails, its picked out and submitted with a PR that contains the fix for the failure.

Currently tests to address has been added:

Missing:

and all the other cases we can and cant think of.

Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1069 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 12/15/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `integration-acl-init` --- ### 📄 Description This PR contains integration tests for ACLs, most of them will likely fail as they are not correctly implemented in Headscale and I suspect this will be the way forward: If a test _passes_ its picked out and submitted as a PR that we can have now. if a test _fails_, its picked out and submitted with a PR that contains the fix for the failure. Currently tests to address has been added: - https://github.com/juanfont/headscale/issues/941 - https://github.com/juanfont/headscale/issues/699 - parts of https://github.com/juanfont/headscale/issues/809 - https://github.com/juanfont/headscale/issues/1292 Missing: - https://github.com/juanfont/headscale/issues/657 - https://github.com/juanfont/headscale/issues/661 (SSH ACLs) and all the other cases we can and cant think of. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 02:31:59 +01:00
adam closed this issue 2025-12-29 02:31:59 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1855
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?