starred/headscale
1
0
Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-01-13 12:50:32 +01:00
Code Issues 98 Packages Projects Releases 10 Wiki Activity

[PR #1254] [MERGED] MapResponse optimalisations, peer list integration tests #1995

New Issue
Closed
opened 2025-12-29 03:19:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 03:19:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/juanfont/headscale/pull/1254
Author: @kradalby
Created: 3/6/2023
Status: ✅ Merged
Merged: 3/6/2023
Merged by: @kradalby

Base: main ← Head: node-in-netmap-test-optimal

📝 Commits (4)

  • bd44f41 Use map instead of for to speed up the lookup
  • 6483cad acl: split, document, cleanup speed up work from @QZAiXH
  • deef052 acl-integration: add tests to verify peer count in client state
  • fc03dd1 Fix lint

📊 Changes

7 files changed (+362 additions, -85 deletions)

View changed files

➕ .github/workflows/test-integration-v2-TestACLHostsInNetMapTable.yaml (+57 -0)
📝 acls.go (+32 -0)
📝 app.go (+5 -3)
➕ integration/acl_test.go (+181 -0)
📝 machine.go (+76 -66)
📝 machine_test.go (+11 -6)
📝 utils.go (+0 -10)

📄 Description

This PR picks up @QZAiXH changes from #1239, but rewrites them slightly to make it conform more to the current code and adds documentation.

In addition it lifts one of the ACL integration tests from my experimental #1069 PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/juanfont/headscale/pull/1254 **Author:** [@kradalby](https://github.com/kradalby) **Created:** 3/6/2023 **Status:** ✅ Merged **Merged:** 3/6/2023 **Merged by:** [@kradalby](https://github.com/kradalby) **Base:** `main` ← **Head:** `node-in-netmap-test-optimal` --- ### 📝 Commits (4) - [`bd44f41`](https://github.com/juanfont/headscale/commit/bd44f41c465ccabd28bf986054bc47e79cd9ebd2) Use map instead of for to speed up the lookup - [`6483cad`](https://github.com/juanfont/headscale/commit/6483cad84e825e943ef2fb581637346ddf2002a1) acl: split, document, cleanup speed up work from @QZAiXH - [`deef052`](https://github.com/juanfont/headscale/commit/deef0527076ce33185eee969b6ffa58de6ec0477) acl-integration: add tests to verify peer count in client state - [`fc03dd1`](https://github.com/juanfont/headscale/commit/fc03dd1423bccee22c205f1743236e2bab426fca) Fix lint ### 📊 Changes **7 files changed** (+362 additions, -85 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/test-integration-v2-TestACLHostsInNetMapTable.yaml` (+57 -0) 📝 `acls.go` (+32 -0) 📝 `app.go` (+5 -3) ➕ `integration/acl_test.go` (+181 -0) 📝 `machine.go` (+76 -66) 📝 `machine_test.go` (+11 -6) 📝 `utils.go` (+0 -10) </details> ### 📄 Description This PR picks up @QZAiXH changes from #1239, but rewrites them slightly to make it conform more to the current code and adds documentation. In addition it lifts one of the ACL integration tests from my experimental #1069 PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 03:19:12 +01:00
adam closed this issue 2025-12-29 03:19:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
CLI
DERP
DNS
Nix
OIDC
SSH
bug
database
documentation
duplicate
enhancement
faq
good first issue
grants
help wanted
might-come
needs design doc
needs investigation
no-stale-bot
out of scope
performance
policy 📝
pull-request
Mirrored from GitHub Pull Request
 question
regression
routes
stale
tags
tailscale-feature-gap
well described ❤️
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/headscale#1995
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?