[PR #473] [MERGED] Fix globbing of CONFIG_D *.sh files #847

New Issue

adam · 2025-12-29T01:29:38+01:00

adam commented

2025-12-29 01:29:38 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/473
Author: @GUI
Created: 2/4/2018
Status: ✅ Merged
Merged: 2/4/2018
Merged by: @lukas2511

Base: master ← Head: config-globbing

📝 Commits (1)

0bc0bd1 Fix globbing of CONFIG_D *.sh files.

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 dehydrated (+7 -1)

📄 Description

With the globbing changes made in 61083cf522 to globally disable globbing by default, this broke the ability to load the CONFIG_D *.sh files.

This re-enables globbing when reading these *.sh files and then disables it again afterwards. Note that this also keeps globbing enabled inside the loop, when sourcing the individual *.sh files for backwards compatibility (so if the individual config scripts relied on the default of globbing being enabled, there won't be any change in behavior).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/473 **Author:** [@GUI](https://github.com/GUI) **Created:** 2/4/2018 **Status:** ✅ Merged **Merged:** 2/4/2018 **Merged by:** [@lukas2511](https://github.com/lukas2511) **Base:** `master` ← **Head:** `config-globbing` --- ### 📝 Commits (1) - [`0bc0bd1`](https://github.com/dehydrated-io/dehydrated/commit/0bc0bd13d6abdc027c58bec12f7c2d3198d3a677) Fix globbing of CONFIG_D *.sh files. ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+7 -1) </details> ### 📄 Description With the globbing changes made in 61083cf52231e09e3a9b599d602c06978704ec57 to globally disable globbing by default, this broke the ability to load the CONFIG_D `*.sh` files. This re-enables globbing when reading these `*.sh` files and then disables it again afterwards. Note that this also keeps globbing enabled inside the loop, when sourcing the individual `*.sh` files for backwards compatibility (so if the individual config scripts relied on the default of globbing being enabled, there won't be any change in behavior). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 01:29:38 +01:00

adam closed this issue

2025-12-29 01:29:39 +01:00

adam referenced this issue

2025-12-29 02:18:39 +01:00

[PR #847] [CLOSED] Fix hook based challenges if the same domain appears twice or more #945

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#847