mirror of
https://github.com/dehydrated-io/dehydrated.git
synced 2026-01-11 22:30:44 +01:00
Account base64 representation is calculated with "\n" #473
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @domrim on GitHub (Apr 17, 2020).
Hi, at first: Thanks for this great piece of software :)
i stumbled upon a small issue with the account urlbase64 creation. the issue is in line 233 and 236 where
CAHASHandOLDCAHASHare created:dbb0ef1ce1/dehydrated (L232-L244)because the CA-String gets echoed with
echo ${CA}and notecho -n {CA}"the actual string which gets Base64 encoded is "https://acme-v02.api.letsencrypt.org/directory\n" instead of "https://acme-v02.api.letsencrypt.org/directory" (for the default${CA}value).I don't know if this issue is fixable because it would require to rename the account folder for all existing users, but i wanted to let you know of the issue. I also wouldn't see this as a large issue, it just fell on my feet when i wanted to calculate the base64 string within python.
@lukas2511 commented on GitHub (Apr 17, 2020):
Yea this is something I'll just leave as is since it's not really disturbing operation, maybe I'll sneak in a little note for developers with the next commit ;) Thanks for reporting!