[PR #847] [CLOSED] Fix hook based challenges if the same domain appears twice or more #945

New Issue

adam · 2025-12-29T02:18:39+01:00

adam commented

2025-12-29 02:18:39 +01:00

📋 Pull Request Information

Original PR: https://github.com/dehydrated-io/dehydrated/pull/847
Author: @jcmoraisjr
Created: 10/17/2021
Status: ❌ Closed

Base: master ← Head: jm-fix-dns-challenge

📝 Commits (1)

d2780f7 fix hook based challenges if the same domain appears twice or more

📊 Changes

1 file changed (+7 additions, -11 deletions)

View changed files

📝 dehydrated (+7 -11)

📄 Description

When two or more domains are present in the challenge, all the hook calls happen before asking the acme server to verify the challenge. This is breaking configurations that need to verify the same domain more than once, e.g. dns based challenges with example.com. and *.example.com. In this case, example.com will be verified twice, maybe with distinct tokens, leading to the second configuration overwriting the first one before the challenge verification.

This update moves the hook call into the while-loop that asks the acme server to verify the challenge, so a second configuration will only happen after the first one has being verified.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dehydrated-io/dehydrated/pull/847 **Author:** [@jcmoraisjr](https://github.com/jcmoraisjr) **Created:** 10/17/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `jm-fix-dns-challenge` --- ### 📝 Commits (1) - [`d2780f7`](https://github.com/dehydrated-io/dehydrated/commit/d2780f76bf3b2ece3b198631969e22d1ca227c9a) fix hook based challenges if the same domain appears twice or more ### 📊 Changes **1 file changed** (+7 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `dehydrated` (+7 -11) </details> ### 📄 Description When two or more domains are present in the challenge, all the hook calls happen before asking the acme server to verify the challenge. This is breaking configurations that need to verify the same domain more than once, e.g. dns based challenges with `example.com`. and `*.example.com`. In this case, `example.com` will be verified twice, maybe with distinct tokens, leading to the second configuration overwriting the first one before the challenge verification. This update moves the hook call into the while-loop that asks the acme server to verify the challenge, so a second configuration will only happen after the first one has being verified. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 02:18:39 +01:00

adam closed this issue

2025-12-29 02:18:39 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/dehydrated#945