starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #4404] [MERGED] Update podcast episode downloads to have a fallback user agent string #4241

New Issue
Closed
opened 2026-04-25 00:18:57 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:18:57 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/4404
Author: @advplyr
Created: 6/13/2025
Status: ✅ Merged
Merged: 6/13/2025
Merged by: @advplyr

Base: master ← Head: podcast_useragents

📝 Commits (1)

  • 777a055 Update podcast episode downloads to have a fallback user agent string

📊 Changes

1 file changed (+33 additions, -12 deletions)

View changed files

📝 server/utils/ffmpegHelpers.js (+33 -12)

📄 Description

Brief summary

Some podcasts fail with different user agents

Which issue is fixed?

Fixes #4401
Related #3246
Related #3322

In-depth Description

This will have podcast episode downloads fallback to another user agent string on any failure.
Primary user-agent: audiobookshelf (+https://audiobookshelf.org; like iTMS)
Fallback user-agent: audiobookshelf (+https://audiobookshelf.org)

RSS feed: https://www1.nobexpartners.com/getfeed.ashx?id=46434&list=LIRAZ
Can download with the primary user-agent but not the fallback user-agent (reported in #4401)

RSS feed: https://feeds.captivate.fm/james-obrien-the-who/
Fails to download using the primary user-agent but works with the fallback (reported in #3246)

A related user-agent issue was with requesting the RSS feed (not downloading) for CBC podcasts (reported in #3322)

The user-agent was first added here #3099 and was previously the default axios one

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/4404 **Author:** [@advplyr](https://github.com/advplyr) **Created:** 6/13/2025 **Status:** ✅ Merged **Merged:** 6/13/2025 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `podcast_useragents` --- ### 📝 Commits (1) - [`777a055`](https://github.com/advplyr/audiobookshelf/commit/777a055fcd4ec5b4f9f1912f30a4c68b51a6b402) Update podcast episode downloads to have a fallback user agent string ### 📊 Changes **1 file changed** (+33 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `server/utils/ffmpegHelpers.js` (+33 -12) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary Some podcasts fail with different user agents ## Which issue is fixed? Fixes #4401 Related #3246 Related #3322 ## In-depth Description This will have podcast episode downloads fallback to another user agent string on any failure. Primary user-agent: `audiobookshelf (+https://audiobookshelf.org; like iTMS)` Fallback user-agent: `audiobookshelf (+https://audiobookshelf.org)` RSS feed: https://www1.nobexpartners.com/getfeed.ashx?id=46434&list=LIRAZ Can download with the primary user-agent but not the fallback user-agent (reported in #4401) RSS feed: https://feeds.captivate.fm/james-obrien-the-who/ Fails to download using the primary user-agent but works with the fallback (reported in #3246) A related user-agent issue was with requesting the RSS feed (not downloading) for CBC podcasts (reported in #3322) The user-agent was first added here #3099 and was previously the default axios one --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:18:57 +02:00
adam closed this issue 2026-04-25 00:18:57 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4241
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?