starred/audiobookshelf
1
0
Fork 0
mirror of https://github.com/advplyr/audiobookshelf.git synced 2026-05-30 23:40:40 +02:00
Code Issues 1.0k Packages Projects Releases 10 Wiki Activity

[PR #5042] [MERGED] Fix OpenAPI spec description #4401

New Issue
Closed
opened 2026-04-25 00:19:36 +02:00 by adam · 0 comments
adam commented 2026-04-25 00:19:36 +02:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/advplyr/audiobookshelf/pull/5042
Author: @openam
Created: 2/8/2026
Status: ✅ Merged
Merged: 2/9/2026
Merged by: @advplyr

Base: master ← Head: open-api-spec-fixes

📝 Commits (1)

  • dd4fc09 Fix OpenAPI spec description

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 custom-metadata-provider-specification.yaml (+1 -1)

📄 Description

Brief summary

I tried to implement a Custom Metadata Provider, and when I tried to use it my times were way too long with parsing the duration into seconds. The results came out correctly when I set the duration as minutes.

Which issue is fixed?

I didn't create an issue. I searched quickly, and didn't see anything.

In-depth Description

How have you tested this?

Screenshots

With parsing duration into seconds
image

With parsing duration into minutes
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/advplyr/audiobookshelf/pull/5042 **Author:** [@openam](https://github.com/openam) **Created:** 2/8/2026 **Status:** ✅ Merged **Merged:** 2/9/2026 **Merged by:** [@advplyr](https://github.com/advplyr) **Base:** `master` ← **Head:** `open-api-spec-fixes` --- ### 📝 Commits (1) - [`dd4fc09`](https://github.com/advplyr/audiobookshelf/commit/dd4fc09909a0a2862756292b11fd684b2f427c1f) Fix OpenAPI spec description ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `custom-metadata-provider-specification.yaml` (+1 -1) </details> ### 📄 Description <!-- For Work In Progress Pull Requests, please use the Draft PR feature, see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for further details. If you do not follow this template, the PR may be closed without review. Please ensure all checks pass. If you are a new contributor, the workflows will need to be manually approved before they run. --> ## Brief summary I tried to implement a Custom Metadata Provider, and when I tried to use it my times were way too long with parsing the duration into seconds. The results came out correctly when I set the duration as minutes. <!-- Please provide a brief summary of what your PR attempts to achieve. --> ## Which issue is fixed? I didn't create an issue. I searched quickly, and didn't see anything. <!-- Which issue number does this PR fix? Ex: "Fixes #1234" --> ## In-depth Description <!-- Describe your solution in more depth. How does it work? Why is this the best solution? Does it solve a problem that affects multiple users or is this an edge case for your setup? --> ## How have you tested this? <!-- Please describe in detail with reproducible steps how you tested your changes. --> ## Screenshots With parsing duration into seconds <img width="212" height="35" alt="image" src="https://github.com/user-attachments/assets/6f81e9ef-0e47-43de-a70d-9df55e7dd4d7" /> With parsing duration into minutes <img width="222" height="37" alt="image" src="https://github.com/user-attachments/assets/2718c397-1d20-4e59-afd8-f297f176b5e6" /> <!-- If your PR includes any changes to the web client, please include screenshots or a short video from before and after your changes. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2026-04-25 00:19:36 +02:00
adam closed this issue 2026-04-25 00:19:36 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
authentication
backlog
bug
chapter editor
config-issue
ebooks
encoding/embedding
enhancement
help wanted
listening sessions & progress
planned
possible plugin
progress sync
pull-request
Mirrored from GitHub Pull Request
 sorting/filtering/searching
unable to reproduce
upload
users & permissions
waiting
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/audiobookshelf#4401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?