mirror of
https://github.com/eitchtee/WYGIWYH.git
synced 2026-11-17 06:11:27 +01:00
fix(sharing): clarify what shared and public visibility allow
"Only editable by the owner" read as covering an account's transactions too, which led to GHSA-36w2-769w-h62g being reported. Sharing an account or making it public deliberately opens its ledger to everyone who can see it; only the object itself stays owner-only. State that in the generic visibility help text, and spell out the account case on the account share panel.
This commit is contained in:
1 parent
11c9d60954
commit
66351aee49
2 files changed
+5
-2
No files matched your search
@@ -40,9 +40,11 @@ class SharedObjectForm(forms.Form):
|
||||
label=_("Visibility"),
|
||||
widget=TomSelect(clear_button=False),
|
||||
help_text=_(
|
||||
"Private: Only shown for the owner and shared users. Only editable by the owner."
|
||||
"Private: Only shown for the owner and shared users."
|
||||
"<br/>"
|
||||
"Public: Shown for all users. Only editable by the owner."
|
||||
"Public: Shown for all users."
|
||||
"<br/>"
|
||||
"Only the owner can edit, share or delete it."
|
||||
),
|
||||
)
|
||||
|
||||
|
||||
@@ -5,6 +5,7 @@
|
||||
{% block title %}{% translate 'Share settings' %}{% endblock %}
|
||||
|
||||
{% block body %}
|
||||
<p class="text-sm text-base-content/70 mb-3">{% translate "Everyone who can see this account can add, edit and delete its transactions, installment plans and recurring transactions." %}</p>
|
||||
<form hx-post="{% url "account_share_settings" pk=object.id %}" hx-target="#generic-offcanvas" novalidate>
|
||||
{% crispy form %}
|
||||
</form>
|
||||
|
||||
Reference in new issue
Block a user