From 66351aee495965d7f5ced8b8b275aebbf265c8d7 Mon Sep 17 00:00:00 2001 From: Herculino Trotta Date: Sat, 14 Nov 2026 03:18:37 -0300 Subject: [PATCH] fix(sharing): clarify what shared and public visibility allow "Only editable by the owner" read as covering an account's transactions too, which led to GHSA-36w2-769w-h62g being reported. Sharing an account or making it public deliberately opens its ledger to everyone who can see it; only the object itself stays owner-only. State that in the generic visibility help text, and spell out the account case on the account share panel. --- app/apps/common/forms.py | 6 ++++-- app/templates/accounts/fragments/share.html | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/apps/common/forms.py b/app/apps/common/forms.py index 9f6ca959..560af509 100644 --- a/app/apps/common/forms.py +++ b/app/apps/common/forms.py @@ -40,9 +40,11 @@ class SharedObjectForm(forms.Form): label=_("Visibility"), widget=TomSelect(clear_button=False), help_text=_( - "Private: Only shown for the owner and shared users. Only editable by the owner." + "Private: Only shown for the owner and shared users." "
" - "Public: Shown for all users. Only editable by the owner." + "Public: Shown for all users." + "
" + "Only the owner can edit, share or delete it." ), ) diff --git a/app/templates/accounts/fragments/share.html b/app/templates/accounts/fragments/share.html index 6e18189b..bdfb5bfe 100644 --- a/app/templates/accounts/fragments/share.html +++ b/app/templates/accounts/fragments/share.html @@ -5,6 +5,7 @@ {% block title %}{% translate 'Share settings' %}{% endblock %} {% block body %} +

{% translate "Everyone who can see this account can add, edit and delete its transactions, installment plans and recurring transactions." %}

{% crispy form %}