Original PR: https://github.com/dscyrescotti/Memola/pull/68 Author: @dscyrescotti Created: 7/19/2024 Status: ✅ Merged Merged: 7/19/2024 Merged by: @dscyrescotti
Base: main ← Head: feature/app-icon
main
feature/app-icon
114e644
8221235
b204a6c
5dc8779
20 files changed (+154 additions, -3 deletions)
📝 Memola.xcodeproj/project.pbxproj (+14 -0) 📝 Memola/Config/Info.plist (+4 -2) 📝 Memola/Features/Dashboard/Details/Shared/MemoPreview.swift (+1 -1) 📝 Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/Contents.json (+61 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-ios.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-1024.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-128.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-16.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-256 1.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-256.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-32 1.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-32.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-512 1.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-512.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-64.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/Contents.json (+23 -0) ➕ Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/launch-logo.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/launch-logo@2x.png (+0 -0) ➕ Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/launch-logo@3x.png (+0 -0) ➕ Memola/Resources/LaunchScreen/LaunchScreen.storyboard (+51 -0)
Memola.xcodeproj/project.pbxproj
Memola/Config/Info.plist
Memola/Features/Dashboard/Details/Shared/MemoPreview.swift
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/Contents.json
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-ios.png
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-1024.png
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-128.png
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-16.png
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-256 1.png
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-256.png
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-32 1.png
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-32.png
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-512 1.png
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-512.png
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-64.png
Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/Contents.json
Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/launch-logo.png
Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/launch-logo@2x.png
Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/launch-logo@3x.png
Memola/Resources/LaunchScreen/LaunchScreen.storyboard
This PR adds app icon for both iOS and macOS along with launch screen for iOS target.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
No dependencies set.
The note is not visible to the blocked user.
📋 Pull Request Information
Original PR: https://github.com/dscyrescotti/Memola/pull/68
Author: @dscyrescotti
Created: 7/19/2024
Status: ✅ Merged
Merged: 7/19/2024
Merged by: @dscyrescotti
Base:
main← Head:feature/app-icon📝 Commits (4)
114e644feat: add app icon for both ios and macos8221235feat: add launch screen for iosb204a6cbug: fix negative dimension5dc8779feat: exclude launch screen from macos📊 Changes
20 files changed (+154 additions, -3 deletions)
View changed files
📝
Memola.xcodeproj/project.pbxproj(+14 -0)📝
Memola/Config/Info.plist(+4 -2)📝
Memola/Features/Dashboard/Details/Shared/MemoPreview.swift(+1 -1)📝
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/Contents.json(+61 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-ios.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-1024.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-128.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-16.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-256 1.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-256.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-32 1.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-32.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-512 1.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-512.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/AppIcon.appiconset/app-icon-macos-64.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/Contents.json(+23 -0)➕
Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/launch-logo.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/launch-logo@2x.png(+0 -0)➕
Memola/Resources/Assets/Assets.xcassets/LaunchIcon.imageset/launch-logo@3x.png(+0 -0)➕
Memola/Resources/LaunchScreen/LaunchScreen.storyboard(+51 -0)📄 Description
Description
This PR adds app icon for both iOS and macOS along with launch screen for iOS target.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.