starred/Memola
1
0
Fork 0
mirror of https://github.com/dscyrescotti/Memola.git synced 2026-01-11 20:00:24 +01:00
Code Issues 5 Packages Projects Releases 3 Wiki Activity

[PR #72] [MERGED] Separate strokes if erasers do not match #75

New Issue
Closed
opened 2025-12-29 05:19:30 +01:00 by adam · 0 comments
adam commented 2025-12-29 05:19:30 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dscyrescotti/Memola/pull/72
Author: @dscyrescotti
Created: 11/24/2024
Status: ✅ Merged
Merged: 11/24/2024
Merged by: @dscyrescotti

Base: main ← Head: bug/eraser-stroke

📝 Commits (1)

  • d8b3362 bug: separate strokes if erasers do not match

📊 Changes

1 file changed (+25 additions, -1 deletions)

View changed files

📝 Memola/Canvas/Elements/Core/ElementGroup.swift (+25 -1)

📄 Description

Description

This PR fixes eraser effect applying to overlaying strokes that matches color. Instead of adding them into the same element group, the new element group for them to separate from the previous strokes.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dscyrescotti/Memola/pull/72 **Author:** [@dscyrescotti](https://github.com/dscyrescotti) **Created:** 11/24/2024 **Status:** ✅ Merged **Merged:** 11/24/2024 **Merged by:** [@dscyrescotti](https://github.com/dscyrescotti) **Base:** `main` ← **Head:** `bug/eraser-stroke` --- ### 📝 Commits (1) - [`d8b3362`](https://github.com/dscyrescotti/Memola/commit/d8b3362a18e00c50cc3c026affa4443ecf4c16ed) bug: separate strokes if erasers do not match ### 📊 Changes **1 file changed** (+25 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Memola/Canvas/Elements/Core/ElementGroup.swift` (+25 -1) </details> ### 📄 Description ### Description This PR fixes eraser effect applying to overlaying strokes that matches color. Instead of adding them into the same element group, the new element group for them to separate from the previous strokes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 05:19:30 +01:00
adam closed this issue 2025-12-29 05:19:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Memola#75
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?