starred/Memola
1
0
Fork 0
mirror of https://github.com/dscyrescotti/Memola.git synced 2026-01-11 20:00:24 +01:00
Code Issues 5 Packages Projects Releases 3 Wiki Activity

[PR #59] [MERGED] Implement preview display for memo #68

New Issue
Closed
opened 2025-12-29 05:19:27 +01:00 by adam · 0 comments
adam commented 2025-12-29 05:19:27 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dscyrescotti/Memola/pull/59
Author: @dscyrescotti
Created: 7/5/2024
Status: ✅ Merged
Merged: 7/5/2024
Merged by: @dscyrescotti

Base: main ← Head: feature/preview

📝 Commits (3)

  • c46424b feat: add memo preview generation
  • aa5f230 feat: add padding to preview image
  • 16e5251 feat: update padding

📊 Changes

21 files changed (+381 additions, -51 deletions)

View changed files

📝 Memola.xcodeproj/project.pbxproj (+8 -0)
📝 Memola/Canvas/Core/Canvas.swift (+49 -0)
📝 Memola/Canvas/Core/Renderer.swift (+20 -0)
📝 Memola/Canvas/Core/Textures.swift (+23 -0)
📝 Memola/Canvas/Elements/Core/Element.swift (+9 -0)
📝 Memola/Canvas/RenderPasses/EraserRenderPass.swift (+14 -1)
📝 Memola/Canvas/RenderPasses/GraphicRenderPass.swift (+1 -1)
📝 Memola/Canvas/RenderPasses/PhotoRenderPass.swift (+14 -1)
➕ Memola/Canvas/RenderPasses/PreviewRenderPass.swift (+119 -0)
📝 Memola/Canvas/RenderPasses/StrokeRenderPass.swift (+20 -2)
📝 Memola/Canvas/View/Bridge/ViewController/CanvasViewController.swift (+1 -0)
➕ Memola/Extensions/MTLTexture++.swift (+48 -0)
📝 Memola/Features/Dashboard/Details/Memos/MemosView.swift (+5 -5)
📝 Memola/Features/Dashboard/Details/Shared/MemoCard.swift (+5 -3)
📝 Memola/Features/Dashboard/Details/Shared/MemoGrid.swift (+20 -14)
📝 Memola/Features/Dashboard/Details/Shared/MemoPreview.swift (+15 -3)
📝 Memola/Features/Dashboard/Details/Trash/TrashView.swift (+5 -5)
📝 Memola/Features/Dashboard/Sidebar/Sidebar.swift (+1 -1)
📝 Memola/Features/Memo/Toolbar/Toolbar.swift (+2 -15)
📝 Memola/Persistence/Objects/MemoObject.swift (+1 -0)

...and 1 more files

📄 Description

Description

This PR implements the display of preview for memo's graphic context along with render pass for preview rendering and persistence for preview image data.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dscyrescotti/Memola/pull/59 **Author:** [@dscyrescotti](https://github.com/dscyrescotti) **Created:** 7/5/2024 **Status:** ✅ Merged **Merged:** 7/5/2024 **Merged by:** [@dscyrescotti](https://github.com/dscyrescotti) **Base:** `main` ← **Head:** `feature/preview` --- ### 📝 Commits (3) - [`c46424b`](https://github.com/dscyrescotti/Memola/commit/c46424ba87cb75828874c6137793b1877c8ec5a5) feat: add memo preview generation - [`aa5f230`](https://github.com/dscyrescotti/Memola/commit/aa5f230822f3e3e9f64408086161d8346d2b7f15) feat: add padding to preview image - [`16e5251`](https://github.com/dscyrescotti/Memola/commit/16e525139619aab2435e4d77ed058f540cf3b85a) feat: update padding ### 📊 Changes **21 files changed** (+381 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `Memola.xcodeproj/project.pbxproj` (+8 -0) 📝 `Memola/Canvas/Core/Canvas.swift` (+49 -0) 📝 `Memola/Canvas/Core/Renderer.swift` (+20 -0) 📝 `Memola/Canvas/Core/Textures.swift` (+23 -0) 📝 `Memola/Canvas/Elements/Core/Element.swift` (+9 -0) 📝 `Memola/Canvas/RenderPasses/EraserRenderPass.swift` (+14 -1) 📝 `Memola/Canvas/RenderPasses/GraphicRenderPass.swift` (+1 -1) 📝 `Memola/Canvas/RenderPasses/PhotoRenderPass.swift` (+14 -1) ➕ `Memola/Canvas/RenderPasses/PreviewRenderPass.swift` (+119 -0) 📝 `Memola/Canvas/RenderPasses/StrokeRenderPass.swift` (+20 -2) 📝 `Memola/Canvas/View/Bridge/ViewController/CanvasViewController.swift` (+1 -0) ➕ `Memola/Extensions/MTLTexture++.swift` (+48 -0) 📝 `Memola/Features/Dashboard/Details/Memos/MemosView.swift` (+5 -5) 📝 `Memola/Features/Dashboard/Details/Shared/MemoCard.swift` (+5 -3) 📝 `Memola/Features/Dashboard/Details/Shared/MemoGrid.swift` (+20 -14) 📝 `Memola/Features/Dashboard/Details/Shared/MemoPreview.swift` (+15 -3) 📝 `Memola/Features/Dashboard/Details/Trash/TrashView.swift` (+5 -5) 📝 `Memola/Features/Dashboard/Sidebar/Sidebar.swift` (+1 -1) 📝 `Memola/Features/Memo/Toolbar/Toolbar.swift` (+2 -15) 📝 `Memola/Persistence/Objects/MemoObject.swift` (+1 -0) _...and 1 more files_ </details> ### 📄 Description ### Description This PR implements the display of preview for memo's graphic context along with render pass for preview rendering and persistence for preview image data. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 05:19:27 +01:00
adam closed this issue 2025-12-29 05:19:27 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
documentation
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Memola#68
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?