[PR #45] [MERGED] Implement photo insertion #59

New Issue

2025-12-29T05:19:21+01:00

adam commented

2025-12-29 05:19:21 +01:00

📋 Pull Request Information

Original PR: https://github.com/dscyrescotti/Memola/pull/45
Author: @dscyrescotti
Created: 6/17/2024
Status: ✅ Merged
Merged: 6/17/2024
Merged by: @dscyrescotti

Base: main ← Head: feature/photo

📝 Commits (10+)

2d0ca34 feat: wrap stroke object with element object
4d63797 feat: add photo render pass
49e878d feat: add photo picker to select photo from library
5203f39 feat: add camera view
46330b9 feat: implement photo insertion
333a57d feat: save photo in persistence
ec486bf feat: bookmark image file for secure access
f93dbdc feat: delete photo if it is inserted
0044fd3 feat: add dimension
daef167 feat: update ordering

📊 Changes

46 files changed (+1182 additions, -126 deletions)

View changed files

📝 Memola.xcodeproj/project.pbxproj (+97 -1)
➕ Memola/Canvas/Buffers/Vertices/PhotoVertex.swift (+21 -0)
📝 Memola/Canvas/Contexts/GraphicContext.swift (+106 -42)
📝 Memola/Canvas/Core/Canvas.swift (+10 -3)
📝 Memola/Canvas/Core/PipelineStates.swift (+22 -0)
📝 Memola/Canvas/Core/Renderer.swift (+5 -0)
📝 Memola/Canvas/Core/Textures.swift (+23 -1)
➕ Memola/Canvas/Elements/Core/Element.swift (+56 -0)
📝 Memola/Canvas/Elements/Geometries/Primitives/Quad.swift (+0 -0)
📝 Memola/Canvas/Elements/Geometries/Primitives/QuadShape.swift (+0 -0)
📝 Memola/Canvas/Elements/Geometries/Stroke/Algorithms/MovingAverage.swift (+0 -0)
📝 Memola/Canvas/Elements/Geometries/Stroke/Core/AnyStroke.swift (+0 -0)
📝 Memola/Canvas/Elements/Geometries/Stroke/Core/Stroke.swift (+4 -0)
📝 Memola/Canvas/Elements/Geometries/Stroke/Core/StrokeGenerator.swift (+0 -0)
📝 Memola/Canvas/Elements/Geometries/Stroke/Core/StrokeStyle.swift (+0 -0)
📝 Memola/Canvas/Elements/Geometries/Stroke/Generators/SolidPointStrokeGenerator.swift (+0 -0)
📝 Memola/Canvas/Elements/Geometries/Stroke/Strokes/EraserStroke.swift (+0 -0)
📝 Memola/Canvas/Elements/Geometries/Stroke/Strokes/PenStroke.swift (+0 -0)
➕ Memola/Canvas/Elements/Photo/Photo.swift (+117 -0)
📝 Memola/Canvas/History/History.swift (+14 -0)

...and 26 more files

📄 Description

Description

This PR add the photo insertion along the photo render pass and persistence set up.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dscyrescotti/Memola/pull/45 **Author:** [@dscyrescotti](https://github.com/dscyrescotti) **Created:** 6/17/2024 **Status:** ✅ Merged **Merged:** 6/17/2024 **Merged by:** [@dscyrescotti](https://github.com/dscyrescotti) **Base:** `main` ← **Head:** `feature/photo` --- ### 📝 Commits (10+) - [`2d0ca34`](https://github.com/dscyrescotti/Memola/commit/2d0ca3478b99acc3a22e00bd84846f4fd44d348d) feat: wrap stroke object with element object - [`4d63797`](https://github.com/dscyrescotti/Memola/commit/4d637977e1b367c457ad6fed95c66d7c173b3959) feat: add photo render pass - [`49e878d`](https://github.com/dscyrescotti/Memola/commit/49e878d0dde2f88449df9df73e63065002b1217e) feat: add photo picker to select photo from library - [`5203f39`](https://github.com/dscyrescotti/Memola/commit/5203f39f96e8c257fe01241627b578b37e36606a) feat: add camera view - [`46330b9`](https://github.com/dscyrescotti/Memola/commit/46330b9a7d281c0ffa98f09d496a207d8baf1503) feat: implement photo insertion - [`333a57d`](https://github.com/dscyrescotti/Memola/commit/333a57da2fa45e6d51d5787fde38efff6847270e) feat: save photo in persistence - [`ec486bf`](https://github.com/dscyrescotti/Memola/commit/ec486bf412ce11049db3c9147d41c8fcfd44ddc8) feat: bookmark image file for secure access - [`f93dbdc`](https://github.com/dscyrescotti/Memola/commit/f93dbdc6a83fdd50e86ec114741bf15fe76e6518) feat: delete photo if it is inserted - [`0044fd3`](https://github.com/dscyrescotti/Memola/commit/0044fd34a3ac9675618ff8ae956b7a3d4292ab37) feat: add dimension - [`daef167`](https://github.com/dscyrescotti/Memola/commit/daef1670bc1413fa1e3dc14d44b3664e43a6b4b4) feat: update ordering ### 📊 Changes **46 files changed** (+1182 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `Memola.xcodeproj/project.pbxproj` (+97 -1) ➕ `Memola/Canvas/Buffers/Vertices/PhotoVertex.swift` (+21 -0) 📝 `Memola/Canvas/Contexts/GraphicContext.swift` (+106 -42) 📝 `Memola/Canvas/Core/Canvas.swift` (+10 -3) 📝 `Memola/Canvas/Core/PipelineStates.swift` (+22 -0) 📝 `Memola/Canvas/Core/Renderer.swift` (+5 -0) 📝 `Memola/Canvas/Core/Textures.swift` (+23 -1) ➕ `Memola/Canvas/Elements/Core/Element.swift` (+56 -0) 📝 `Memola/Canvas/Elements/Geometries/Primitives/Quad.swift` (+0 -0) 📝 `Memola/Canvas/Elements/Geometries/Primitives/QuadShape.swift` (+0 -0) 📝 `Memola/Canvas/Elements/Geometries/Stroke/Algorithms/MovingAverage.swift` (+0 -0) 📝 `Memola/Canvas/Elements/Geometries/Stroke/Core/AnyStroke.swift` (+0 -0) 📝 `Memola/Canvas/Elements/Geometries/Stroke/Core/Stroke.swift` (+4 -0) 📝 `Memola/Canvas/Elements/Geometries/Stroke/Core/StrokeGenerator.swift` (+0 -0) 📝 `Memola/Canvas/Elements/Geometries/Stroke/Core/StrokeStyle.swift` (+0 -0) 📝 `Memola/Canvas/Elements/Geometries/Stroke/Generators/SolidPointStrokeGenerator.swift` (+0 -0) 📝 `Memola/Canvas/Elements/Geometries/Stroke/Strokes/EraserStroke.swift` (+0 -0) 📝 `Memola/Canvas/Elements/Geometries/Stroke/Strokes/PenStroke.swift` (+0 -0) ➕ `Memola/Canvas/Elements/Photo/Photo.swift` (+117 -0) 📝 `Memola/Canvas/History/History.swift` (+14 -0) _...and 26 more files_ </details> ### 📄 Description ### Description This PR add the photo insertion along the photo render pass and persistence set up. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 05:19:21 +01:00

adam closed this issue

2025-12-29 05:19:21 +01:00

adam referenced this issue

2025-12-29 05:19:27 +01:00

[PR #59] [MERGED] Implement preview display for memo #68

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Memola#59