#34 Change use of deprecated NetworkInfo enhancement (#38)

* replace NetworkInto with the ConnectivityManager. Since this network validation is being done at repository level, I've had to add the network dependency on it's own AndroidManifest.

* moved network_state_permission from repository manifest to app's manifest.
removed wildcard imports.
now, network_info it's been provided and not the connectivity_manager

app/src/main/AndroidManifest.xml

@@ -4,6 +4,7 @@
     package="com.melih.rocketscience">
 
     <uses-permission android:name="android.permission.INTERNET" />
+    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
 
     <application
         android:name=".App"

core/src/main/kotlin/com/melih/core/di/CoreModule.kt

@@ -14,6 +14,10 @@ class CoreModule {
     fun proivdeAppContext(app: Application): Context = app.applicationContext
 
     @Provides
-    fun provideNetworkInfo(app: Application): NetworkInfo? =
-        (app.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager).activeNetworkInfo
+    fun provideNetworkInfo(app: Application): NetworkInfo? {
+        val connectivityManager =
+            app.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager
+        return connectivityManager.activeNetworkInfo
+    }
+
 }

repository/src/main/AndroidManifest.xml

@@ -1,2 +1,2 @@
-<manifest package="com.melih.repository"/>
+<manifest package="com.melih.repository" />