From 8344e7f94bdf4ed46cc4337c1fea6704d7051224 Mon Sep 17 00:00:00 2001
From: Victor Vicari <victor.a.vicari@gmail.com>
Date: Tue, 24 Sep 2019 11:04:02 -0300
Subject: [PATCH] #34 Change use of deprecated NetworkInfo enhancement (#38)

* replace NetworkInto with the ConnectivityManager. Since this network validation is being done at repository level, I've had to add the network dependency on it's own AndroidManifest.

* moved network_state_permission from repository manifest to app's manifest.
removed wildcard imports.
now, network_info it's been provided and not the connectivity_manager
---
 app/src/main/AndroidManifest.xml                     | 1 +
 core/src/main/kotlin/com/melih/core/di/CoreModule.kt | 8 ++++++--
 repository/src/main/AndroidManifest.xml              | 2 +-
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index d905a0d..6013c48 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -4,6 +4,7 @@
     package="com.melih.rocketscience">
 
     <uses-permission android:name="android.permission.INTERNET" />
+    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
 
     <application
         android:name=".App"
diff --git a/core/src/main/kotlin/com/melih/core/di/CoreModule.kt b/core/src/main/kotlin/com/melih/core/di/CoreModule.kt
index bc8aab2..fe9bbf5 100644
--- a/core/src/main/kotlin/com/melih/core/di/CoreModule.kt
+++ b/core/src/main/kotlin/com/melih/core/di/CoreModule.kt
@@ -14,6 +14,10 @@ class CoreModule {
     fun proivdeAppContext(app: Application): Context = app.applicationContext
 
     @Provides
-    fun provideNetworkInfo(app: Application): NetworkInfo? =
-        (app.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager).activeNetworkInfo
+    fun provideNetworkInfo(app: Application): NetworkInfo? {
+        val connectivityManager =
+            app.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager
+        return connectivityManager.activeNetworkInfo
+    }
+
 }
diff --git a/repository/src/main/AndroidManifest.xml b/repository/src/main/AndroidManifest.xml
index 1af640d..efd4c29 100644
--- a/repository/src/main/AndroidManifest.xml
+++ b/repository/src/main/AndroidManifest.xml
@@ -1,2 +1,2 @@
-<manifest package="com.melih.repository"/>
+<manifest package="com.melih.repository" />