Fix Editor.tsx wonkiness

This commit is contained in:
Gregory Schier
2025-11-04 13:44:18 -08:00
parent 4390c02117
commit fa3a0b57f9
5 changed files with 2 additions and 14 deletions

View File

@@ -265,7 +265,6 @@ export function GrpcRequestPane({
</HStack>
</div>
<Tabs
key={forceUpdateKey}
value={activeTab}
label="Request"
onChangeValue={setActiveTab}

View File

@@ -354,7 +354,6 @@ export function HttpRequestPane({ style, fullHeight, className, activeRequest }:
isLoading={activeResponse != null && activeResponse.state !== 'closed'}
/>
<Tabs
key={activeRequest.id} // Freshen tabs on request change
value={activeTab}
label="Request"
onChangeValue={setActiveTab}

View File

@@ -229,7 +229,6 @@ export function WebsocketRequestPane({ style, fullHeight, className, activeReque
/>
</div>
<Tabs
key={activeRequest.id} // Freshen tabs on request change
value={activeTab}
label="Request"
onChangeValue={setActiveTab}

View File

@@ -376,7 +376,7 @@ export function Editor({
// Initialize the editor when ref mounts
const initEditorRef = useCallback(
function initializeCodemirror(container: HTMLDivElement | null) {
function initEditorRef(container: HTMLDivElement | null) {
if (container === null) {
cm.current?.view.destroy();
cm.current = null;
@@ -455,17 +455,9 @@ export function Editor({
}
},
// eslint-disable-next-line react-hooks/exhaustive-deps
[],
[forceUpdateKey],
);
// Update editor doc when force update key changes
useEffect(() => {
if (cm.current?.view != null) {
updateContents(cm.current.view, defaultValue || '');
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [forceUpdateKey]);
// For read-only mode, update content when `defaultValue` changes
useEffect(
function updateReadOnlyEditor() {

View File

@@ -112,7 +112,6 @@ function fieldValueCompletions(
): Completion[] | null {
if (!def || !def.values) return null;
const vals = Array.isArray(def.values) ? def.values : def.values();
// console.log("HELLO", v, v.match(IDENT));
return vals.map((v) => ({
label: v.match(IDENT_ONLY) ? v : `"${v}"`,
displayLabel: v,