starred/yaak-mountain-loop
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 22:40:26 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #250] [CLOSED] [Core] [Auth] Add action to open inherited auth config #175

New Issue
Closed
opened 2025-12-29 08:31:51 +01:00 by adam · 0 comments
adam commented 2025-12-29 08:31:51 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/250
Author: @Moshyfawn
Created: 8/12/2025
Status: ❌ Closed

Base: main ← Head: feat/auth-inherit-expand

📝 Commits (2)

  • 93fac1a feat: add action to open inherited auth config
  • 9fa5bec Merge branch 'main' into feat/auth-inherit-expand

📊 Changes

1 file changed (+23 additions, -7 deletions)

View changed files

📝 src-web/hooks/useAuthTab.tsx (+23 -7)

📄 Description

This PR makes use of the "inheritance" icon button that allows users to navigate to the parent auth config.

I noticed a minor issue with the icon button tooltip - it occasionally gains focus and displays the tooltip at unexpected times. Happy to discuss this further if you'd like.

For this implementation, I've updated the existing hook code to avoid refactoring areas that might be used elsewhere in the app. That said, it might be worth considering separating the view/JSX from the auth logic in a future refactor, as returning JSX directly from hooks isn't typically recommended. Let me know your thoughts on this approach.

https://github.com/user-attachments/assets/0ae754e5-6072-4530-a5d0-808c8906f4af

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/250 **Author:** [@Moshyfawn](https://github.com/Moshyfawn) **Created:** 8/12/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/auth-inherit-expand` --- ### 📝 Commits (2) - [`93fac1a`](https://github.com/mountain-loop/yaak/commit/93fac1af26ecb99faf1685ce1626028b963ad50a) feat: add action to open inherited auth config - [`9fa5bec`](https://github.com/mountain-loop/yaak/commit/9fa5beca4cd18d24b3f3da9a26772fd33a08a34c) Merge branch 'main' into feat/auth-inherit-expand ### 📊 Changes **1 file changed** (+23 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src-web/hooks/useAuthTab.tsx` (+23 -7) </details> ### 📄 Description This PR makes use of the "inheritance" icon button that allows users to navigate to the parent auth config. I noticed a minor issue with the icon button tooltip - it occasionally gains focus and displays the tooltip at unexpected times. Happy to discuss this further if you'd like. For this implementation, I've updated the existing hook code to avoid refactoring areas that might be used elsewhere in the app. That said, it might be worth considering separating the view/JSX from the auth logic in a future refactor, as returning JSX directly from hooks isn't typically recommended. Let me know your thoughts on this approach. https://github.com/user-attachments/assets/0ae754e5-6072-4530-a5d0-808c8906f4af --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 08:31:51 +01:00
adam closed this issue 2025-12-29 08:31:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak-mountain-loop#175
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?