starred/yaak-mountain-loop
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-14 15:53:24 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #328] [MERGED] Fix cookies not being persisted after HTTP requests #250

New Issue
Closed
opened 2025-12-29 08:32:18 +01:00 by adam · 0 comments
adam commented 2025-12-29 08:32:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/328
Author: @gschier
Created: 12/22/2025
Status: ✅ Merged
Merged: 12/22/2025
Merged by: @gschier

Base: main ← Head: claude/debug-yaak-cookies-IGMdj

📝 Commits (1)

  • 31eb74c Fix cookies not being persisted after HTTP requests

📊 Changes

1 file changed (+26 additions, -3 deletions)

View changed files

📝 src-tauri/src/http_request.rs (+26 -3)

📄 Description

Cookies received from Set-Cookie headers were stored in the in-memory
CookieStore but never saved back to the database. Each subsequent request
would reload cookies from the database, losing any cookies received from
previous responses.

This fix extracts cookies from the in-memory store after each request
completes and persists them back to the cookie jar in the database.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/328 **Author:** [@gschier](https://github.com/gschier) **Created:** 12/22/2025 **Status:** ✅ Merged **Merged:** 12/22/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `claude/debug-yaak-cookies-IGMdj` --- ### 📝 Commits (1) - [`31eb74c`](https://github.com/mountain-loop/yaak/commit/31eb74c96243ec4e16f053b8222cb5ede4600550) Fix cookies not being persisted after HTTP requests ### 📊 Changes **1 file changed** (+26 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/src/http_request.rs` (+26 -3) </details> ### 📄 Description Cookies received from Set-Cookie headers were stored in the in-memory CookieStore but never saved back to the database. Each subsequent request would reload cookies from the database, losing any cookies received from previous responses. This fix extracts cookies from the in-memory store after each request completes and persists them back to the cookie jar in the database. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 08:32:18 +01:00
adam closed this issue 2025-12-29 08:32:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak-mountain-loop#250
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?