Close responses before request body history finishes

apps/yaak-client/components/CookieDialog.tsx

@@ -13,7 +13,6 @@ import {
   useState,
 } from "react";
 import { showDialog } from "../lib/dialog";
-import { trackFeatureUsage } from "../lib/featureFeedback";
 import { jotaiStore } from "../lib/jotai";
 import { cookieDomain } from "../lib/model_util";
 import {
@@ -132,7 +131,6 @@ export const CookieDialog = ({ cookieJarId }: Props) => {
     });
 
     void patchModel(cookieJar, { cookies: [...nextCookies, nextCookie] });
-    trackFeatureUsage("cookie-editor");
     setSelectedCookieKey(nextCookieKey);
     setEditingCookieKey(null);
     setDraftCookie(null);

apps/yaak-client/components/FeedbackToast.tsx

@@ -1,65 +0,0 @@
-import { HStack, VStack } from "@yaakapp-internal/ui";
-import { useState } from "react";
-import type { FeedbackFeature } from "../lib/featureFeedback";
-import { FEEDBACK_FEATURES } from "../lib/featureFeedback";
-import { invokeCmd } from "../lib/tauri";
-import { hideToastById, showToast } from "../lib/toast";
-import { Button } from "./core/Button";
-import { Input } from "./core/Input";
-
-interface Props {
-  feature: FeedbackFeature;
-}
-
-export function FeedbackToast({ feature }: Props) {
-  const [text, setText] = useState<string>("");
-
-  const handleDismiss = () => {
-    hideToastById(`feature-feedback-${feature}`);
-  };
-
-  const handleSend = () => {
-    // Fire-and-forget; failures are intentionally ignored
-    invokeCmd("cmd_send_feedback", { feature, text: text.trim() }).catch(() => {});
-    showToast({
-      id: `feature-feedback-${feature}`,
-      timeout: 3000,
-      color: "success",
-      message: "Thanks for the feedback!",
-    });
-  };
-
-  return (
-    <VStack space={2}>
-      <p className="text-sm font-semibold">{FEEDBACK_FEATURES[feature]}</p>
-      <div className="h-20">
-        <Input
-          size="xs"
-          // The editor forces its mono font on the scroller, so the override
-          // has to target it directly
-          className="[&_.cm-scroller]:font-sans! [&_.cm-scroller]:text-sm!"
-          label="Feedback"
-          hideLabel
-          stateKey={null}
-          multiLine
-          fullHeight
-          placeholder="Your thoughts..."
-          onChange={setText}
-        />
-      </div>
-      <HStack space={1.5} justifyContent="end">
-        <Button size="xs" color="secondary" variant="border" onClick={handleDismiss}>
-          Dismiss
-        </Button>
-        <Button
-          size="xs"
-          color="primary"
-          disabled={text.trim().length === 0}
-          onClick={handleSend}
-        >
-          Send
-        </Button>
-      </HStack>
-    </VStack>
-  );
-}

apps/yaak-client/components/RecentHttpResponsesDropdown.tsx

@@ -10,7 +10,6 @@ import {
 } from "date-fns";
 import { useDeleteHttpResponses } from "../hooks/useDeleteHttpResponses";
 import { useKeyValue } from "../hooks/useKeyValue";
-import { trackFeatureUsage } from "../lib/featureFeedback";
 import { DismissibleBanner } from "./core/DismissibleBanner";
 import { Dropdown, type DropdownItem } from "./core/Dropdown";
 import { formatMillis } from "./core/HttpResponseDurationTag";
@@ -93,10 +92,7 @@ export const RecentHttpResponsesDropdown = function ResponsePane({
         </HStack>
       ),
       leftSlot: activeResponse?.id === r.id ? <Icon icon="check" /> : <Icon icon="empty" />,
-      onSelect: () => {
-        if (r.id !== latestResponseId) trackFeatureUsage("response-history");
-        onPinnedResponseId(r.id);
-      },
+      onSelect: () => onPinnedResponseId(r.id),
     });
   }
 

apps/yaak-client/components/Settings/SettingsGeneral.tsx

@@ -102,13 +102,6 @@ export function SettingsGeneral() {
               description="Periodically ping Yaak servers to check for relevant notifications."
             />
 
-            <ModelSettingRowBoolean
-              model={settings}
-              modelKey="hideFeedbackPrompts"
-              title="Never ask for feedback"
-              description="Hide the rare one-time prompts asking how new features are working."
-            />
-
             <SettingRowBoolean
               title="Send anonymous usage statistics"
               description="Yaak is local-first and does not collect analytics or usage data."

apps/yaak-client/components/core/Input.tsx

@@ -318,7 +318,6 @@ function BaseInput({
               editorClassName,
               multiLine && size === "md" && "py-1.5",
               multiLine && size === "sm" && "py-1",
-              multiLine && (size === "xs" || size === "2xs") && "py-0.5",
             )}
             onFocus={handleFocus}
             onBlur={handleBlur}

apps/yaak-client/components/core/Toast.tsx

@@ -15,12 +15,6 @@ export interface ToastProps {
   action?: (args: { hide: () => void }) => ReactNode;
   icon?: ShowToastRequest["icon"] | null;
   color?: ShowToastRequest["color"];
-  // Grow with the content (up to the viewport) instead of scrolling internally
-  // past the default max height
-  dynamicHeight?: boolean;
-  // Hide the close button, for toasts that render their own dismiss action.
-  // Escape still closes the toast
-  hideDismiss?: boolean;
 }
 
 const ICONS: Record<NonNullable<ToastProps["color"] | "custom">, IconProps["icon"] | null> = {
@@ -34,17 +28,7 @@ const ICONS: Record<NonNullable<ToastProps["color"] | "custom">, IconProps["icon
   warning: "alert_triangle",
 };
 
-export function Toast({
-  children,
-  open,
-  onClose,
-  timeout,
-  action,
-  icon,
-  color,
-  dynamicHeight,
-  hideDismiss,
-}: ToastProps) {
+export function Toast({ children, open, onClose, timeout, action, icon, color }: ToastProps) {
   useKey(
     "Escape",
     () => {
@@ -73,13 +57,7 @@ export function Toast({
           "border border-border shadow-lg w-100",
         )}
       >
-        <div
-          className={classNames(
-            "pl-3 py-3 flex items-start gap-2 w-full overflow-auto",
-            hideDismiss ? "pr-3" : "pr-10",
-            dynamicHeight ? "max-h-[80vh]" : "max-h-44",
-          )}
-        >
+        <div className="pl-3 py-3 pr-10 flex items-start gap-2 w-full max-h-44 overflow-auto">
           {toastIcon && <Icon icon={toastIcon} color={color} className="mt-1 shrink-0" />}
           <VStack space={2} className="w-full min-w-0">
             <div className="select-auto">{children}</div>
@@ -87,16 +65,14 @@ export function Toast({
           </VStack>
         </div>
 
-        {!hideDismiss && (
-          <IconButton
-            color={color}
-            variant="border"
-            className="opacity-60 border-0 absolute! top-2 right-2"
-            title="Dismiss"
-            icon="x"
-            onClick={onClose}
-          />
-        )}
+        <IconButton
+          color={color}
+          variant="border"
+          className="opacity-60 border-0 absolute! top-2 right-2"
+          title="Dismiss"
+          icon="x"
+          onClick={onClose}
+        />
 
         {timeout != null && (
           <div className="w-full absolute bottom-0 left-0 right-0">

apps/yaak-client/components/git/GitCommitDialog.tsx

@@ -12,7 +12,6 @@ import { Banner, HStack, Icon, InlineCode, SplitLayout } from "@yaakapp-internal
 import classNames from "classnames";
 import { useCallback, useMemo, useState } from "react";
 import { modelToYaml } from "../../lib/diffYaml";
-import { trackFeatureUsage } from "../../lib/featureFeedback";
 import { resolvedModelName } from "../../lib/resolvedModelName";
 import { showConfirm } from "../../lib/confirm";
 import { showErrorToast } from "../../lib/toast";
@@ -56,7 +55,6 @@ export function GitCommitDialog({ syncDir, onDone, workspace }: Props) {
     setCommitError(null);
     try {
       await commit.mutateAsync({ message });
-      trackFeatureUsage("git-sync");
       onDone();
     } catch (err) {
       setCommitError(String(err));
@@ -68,7 +66,6 @@ export function GitCommitDialog({ syncDir, onDone, workspace }: Props) {
     try {
       const r = await commitAndPush.mutateAsync({ message });
       handlePushResult(r);
-      trackFeatureUsage("git-sync");
       onDone();
     } catch (err) {
       showErrorToast({

apps/yaak-client/components/responseViewers/EventStreamViewer.tsx

@@ -3,7 +3,7 @@ import { extractSseValueAtPath, type ServerSentEvent } from "@yaakapp-internal/s
 import { HStack, Icon, InlineCode, SplitLayout, VStack } from "@yaakapp-internal/ui";
 import classNames from "classnames";
 import type { CSSProperties, ReactNode } from "react";
-import { Fragment, useEffect, useMemo, useState } from "react";
+import { Fragment, useMemo, useState } from "react";
 import { useKeyValue } from "../../hooks/useKeyValue";
 import { useFormatText } from "../../hooks/useFormatText";
 import { useResponseBodyEventSource } from "../../hooks/useResponseBodyEventSource";
@@ -13,7 +13,6 @@ import {
   useSseSummaryResultKeyPath,
 } from "../../hooks/useSseSummaryResultKeyPath";
 import { isJSON } from "../../lib/contentType";
-import { trackFeatureUsage } from "../../lib/featureFeedback";
 import { EmptyStateText } from "../EmptyStateText";
 import { Markdown } from "../Markdown";
 import { Button } from "../core/Button";
@@ -72,16 +71,6 @@ function ActualEventStreamViewer({ response }: Props) {
     summary.data.fragmentCount === 0 &&
     !summary.isFetching &&
     summary.error == null;
-  // The component remounts per response (keyed above), so this counts at most
-  // one use for each response that successfully extracts summary text
-  const hasSummaryFragments = showExtractedText && (summary.data?.fragmentCount ?? 0) > 0;
-  const [trackedSummaryUse, setTrackedSummaryUse] = useState<boolean>(false);
-  useEffect(() => {
-    if (!hasSummaryFragments || trackedSummaryUse) return;
-    setTrackedSummaryUse(true);
-    trackFeatureUsage("sse-summary");
-  }, [hasSummaryFragments, trackedSummaryUse]);
-
   const filterEventPreviews = showExtractedText && filterEventPreviewsSetting.value === true;
   const applyToDetails = showExtractedText && applyToDetailsSetting.value === true;
   const renderMarkdown = showExtractedText && renderMarkdownSetting.value === true;

apps/yaak-client/lib/featureFeedback.tsx

@@ -1,72 +0,0 @@
-import { settingsAtom } from "@yaakapp-internal/models";
-import { FeedbackToast } from "../components/FeedbackToast";
-import { jotaiStore } from "./jotai";
-import { getKeyValue, setKeyValue } from "./keyValueStore";
-import { showToast } from "./toast";
-
-// Feature keys are sent to the server and used to group feedback for analysis.
-// NEVER rename a key once it has shipped, or historical feedback will be split
-// across the old and new names.
-export const FEEDBACK_FEATURES = {
-  "cookie-editor": "How is cookie editing working for you?",
-  "response-history": "How is the new response history menu working for you?",
-  "sse-summary": "How is extracted text for event streams working for you?",
-  "git-sync": "How is Git sync working for you?",
-} as const;
-
-export type FeedbackFeature = keyof typeof FEEDBACK_FEATURES;
-
-interface FeatureFeedbackState {
-  uses: number;
-  done: boolean;
-}
-
-// Ask once the user has used a feature enough times to have formed an opinion
-const PROMPT_AFTER_USES = 3;
-
-// Show at most one feedback prompt per app session to stay unobtrusive
-let promptedThisSession = false;
-
-const kvArgs = (feature: FeedbackFeature) => ({
-  namespace: "global",
-  key: ["feature-feedback", feature],
-});
-
-function getFeatureFeedbackState(feature: FeedbackFeature): FeatureFeedbackState {
-  return getKeyValue<FeatureFeedbackState>({
-    ...kvArgs(feature),
-    fallback: { uses: 0, done: false },
-  });
-}
-
-function patchFeatureFeedbackState(feature: FeedbackFeature, patch: Partial<FeatureFeedbackState>) {
-  const value = { ...getFeatureFeedbackState(feature), ...patch };
-  setKeyValue({ ...kvArgs(feature), value }).catch(console.error);
-}
-
-// Record a successful use of a feature, and prompt for feedback on the Nth use.
-// Nothing is ever sent to the server from here; showing the toast is local-only
-// and a submission only happens when the user clicks Send in it.
-export function trackFeatureUsage(feature: FeedbackFeature) {
-  if (jotaiStore.get(settingsAtom).hideFeedbackPrompts) return;
-
-  const state = getFeatureFeedbackState(feature);
-  if (state.done) return;
-
-  const uses = state.uses + 1;
-  const shouldPrompt = uses >= PROMPT_AFTER_USES && !promptedThisSession;
-
-  // Mark done when prompting so the toast can only ever appear once, even if
-  // the app quits before the user interacts with it
-  patchFeatureFeedbackState(feature, { uses, done: shouldPrompt });
-  if (!shouldPrompt) return;
-
-  promptedThisSession = true;
-  showToast({
-    id: `feature-feedback-${feature}`,
-    timeout: null,
-    dynamicHeight: true,
-    hideDismiss: true,
-    message: <FeedbackToast feature={feature} />,
-  });
-}

apps/yaak-client/lib/tauri.ts

@@ -48,7 +48,6 @@ type TauriCmd =
   | "cmd_save_response"
   | "cmd_secure_template"
   | "cmd_send_ephemeral_request"
-  | "cmd_send_feedback"
   | "cmd_send_http_request"
   | "cmd_template_function_summaries"
   | "cmd_template_function_config"

apps/yaak-client/lib/toast.tsx

@@ -37,11 +37,6 @@ export function showToast({
   return id;
 }
 
-export function hideToastById(id: string) {
-  const toast = jotaiStore.get(toastsAtom).find((t) => t.id === id);
-  if (toast) hideToast(toast);
-}
-
 export function hideToast(toHide: ToastInstance) {
   jotaiStore.set(toastsAtom, (all) => {
     const t = all.find((t) => t.uniqueKey === toHide.uniqueKey);

crates-tauri/yaak-app-client/src/feedback.rs

@@ -1,47 +0,0 @@
-use log::debug;
-use serde::Serialize;
-use tauri::{AppHandle, Runtime, is_dev};
-use yaak_api::{ApiClientKind, yaak_api_client};
-use yaak_common::platform::get_os_str;
-
-#[derive(Serialize)]
-#[serde(rename_all = "camelCase")]
-struct FeedbackPayload {
-    feature: String,
-    text: String,
-    app_version: String,
-    os: String,
-}
-
-/// Send explicit user feedback for a feature. Fire-and-forget: errors are
-/// logged and swallowed so a failed send never surfaces to the user.
-pub async fn send_feedback<R: Runtime>(app_handle: &AppHandle<R>, feature: String, text: String) {
-    let app_version = app_handle.package_info().version.to_string();
-    let payload = FeedbackPayload {
-        feature,
-        text,
-        app_version: app_version.clone(),
-        os: get_os_str().to_string(),
-    };
-
-    let client = match yaak_api_client(ApiClientKind::App, &app_version) {
-        Ok(c) => c,
-        Err(e) => {
-            debug!("Failed to build feedback client: {e:?}");
-            return;
-        }
-    };
-
-    match client.post(build_url("/app-feedback")).json(&payload).send().await {
-        Ok(resp) => debug!("Sent feedback with status {}", resp.status()),
-        Err(e) => debug!("Failed to send feedback: {e:?}"),
-    }
-}
-
-fn build_url(path: &str) -> String {
-    if is_dev() {
-        format!("http://localhost:9444/api/v1{path}")
-    } else {
-        format!("https://api.yaak.app/api/v1{path}")
-    }
-}

crates-tauri/yaak-app-client/src/lib.rs

@@ -65,7 +65,6 @@ use yaak_tls::find_client_certificate;
 mod commands;
 mod encoding;
 mod error;
-mod feedback;
 mod git_ext;
 mod git_watcher;
 mod grpc;
@@ -293,16 +292,6 @@ async fn cmd_render_template<R: Runtime>(
     Ok(result)
 }
 
-#[tauri::command]
-async fn cmd_send_feedback<R: Runtime>(
-    app_handle: AppHandle<R>,
-    feature: String,
-    text: String,
-) -> YaakResult<()> {
-    feedback::send_feedback(&app_handle, feature, text).await;
-    Ok(())
-}
-
 #[tauri::command]
 async fn cmd_dismiss_notification<R: Runtime>(
     window: WebviewWindow<R>,
@@ -1830,7 +1819,6 @@ pub fn run() {
             cmd_delete_send_history,
             cmd_dismiss_notification,
             cmd_export_data,
-            cmd_send_feedback,
             cmd_http_request_body,
             cmd_http_response_body,
             cmd_format_json,

crates-tauri/yaak-system-appearance/src/lib.rs

@@ -1,18 +1,13 @@
 use std::sync::{Arc, Mutex};
-#[cfg(target_os = "linux")]
 use std::time::Duration;
 
-#[cfg(target_os = "linux")]
 use log::{debug, warn};
-#[cfg(target_os = "linux")]
-use tauri::Emitter;
-use tauri::{AppHandle, Runtime};
+use tauri::{AppHandle, Emitter, Runtime};
 
 pub const INITIAL_APPEARANCE_GLOBAL: &str = "__YAAK_INITIAL_APPEARANCE__";
 pub const INITIAL_APPEARANCE_SOURCE_GLOBAL: &str = "__YAAK_INITIAL_APPEARANCE_SOURCE__";
 pub const SYSTEM_APPEARANCE_CHANGE_EVENT: &str = "system_appearance_change";
 
-#[cfg(target_os = "linux")]
 const SYSTEM_APPEARANCE_POLL_INTERVAL: Duration = Duration::from_secs(1);
 
 #[derive(Clone, Copy, Debug, Eq, PartialEq)]
@@ -47,8 +42,6 @@ impl InitialAppearanceSource {
 
 #[derive(Clone)]
 pub struct SystemAppearanceState {
-    // Only read by the Linux polling thread
-    #[cfg_attr(not(target_os = "linux"), allow(dead_code))]
     last_appearance: Arc<Mutex<Option<Appearance>>>,
 }
 

crates/yaak-models/bindings/gen_models.ts

@@ -402,7 +402,6 @@ export type Settings = {
   themeLight: string;
   updateChannel: string;
   hideLicenseBadge: boolean;
-  hideFeedbackPrompts: boolean;
   autoupdate: boolean;
   autoDownloadUpdates: boolean;
   checkNotifications: boolean;

crates/yaak-models/migrations/20260704000000_hide-feedback-prompts.sql

@@ -1,3 +0,0 @@
--- Add a setting to disable in-app feature feedback prompts
-ALTER TABLE settings
-    ADD COLUMN hide_feedback_prompts BOOLEAN DEFAULT FALSE NOT NULL;

crates/yaak-models/src/models.rs

@@ -246,7 +246,6 @@ pub struct Settings {
     pub theme_light: String,
     pub update_channel: String,
     pub hide_license_badge: bool,
-    pub hide_feedback_prompts: bool,
     pub autoupdate: bool,
     pub auto_download_updates: bool,
     pub check_notifications: bool,
@@ -304,7 +303,6 @@ impl UpsertModelInfo for Settings {
             (ThemeLight, self.theme_light.as_str().into()),
             (UpdateChannel, self.update_channel.into()),
             (HideLicenseBadge, self.hide_license_badge.into()),
-            (HideFeedbackPrompts, self.hide_feedback_prompts.into()),
             (Autoupdate, self.autoupdate.into()),
             (AutoDownloadUpdates, self.auto_download_updates.into()),
             (ColoredMethods, self.colored_methods.into()),
@@ -334,7 +332,6 @@ impl UpsertModelInfo for Settings {
             SettingsIden::ThemeLight,
             SettingsIden::UpdateChannel,
             SettingsIden::HideLicenseBadge,
-            SettingsIden::HideFeedbackPrompts,
             SettingsIden::Autoupdate,
             SettingsIden::AutoDownloadUpdates,
             SettingsIden::ColoredMethods,
@@ -375,7 +372,6 @@ impl UpsertModelInfo for Settings {
             autoupdate: row.get("autoupdate")?,
             auto_download_updates: row.get("auto_download_updates")?,
             hide_license_badge: row.get("hide_license_badge")?,
-            hide_feedback_prompts: row.get("hide_feedback_prompts")?,
             colored_methods: row.get("colored_methods")?,
             check_notifications: row.get("check_notifications")?,
             hotkeys: serde_json::from_str(&hotkeys).unwrap_or_default(),

crates/yaak-models/src/queries/settings.rs

@@ -38,7 +38,6 @@ impl<'a> ClientDb<'a> {
             autoupdate: true,
             colored_methods: false,
             hide_license_badge: false,
-            hide_feedback_prompts: false,
             auto_download_updates: true,
             check_notifications: true,
             hotkeys: HashMap::new(),

crates/yaak/src/send.rs

@@ -511,7 +511,10 @@ pub async fn send_http_request<T: TemplateCallback>(
             .map_err(SendHttpRequestError::PrepareSendableRequest)?;
     }
 
-    let request_content_length = sendable_body_length(sendable_request.body.as_ref());
+    let request_content_length = match sendable_request.body.as_ref() {
+        Some(SendableBody::Bytes(_)) => sendable_body_length(sendable_request.body.as_ref()),
+        Some(SendableBody::Stream { .. }) | None => None,
+    };
     let mut response = params.existing_response.unwrap_or_default();
     response.request_id = params.request.id.clone();
     response.workspace_id = params.request.workspace_id.clone();
@@ -811,16 +814,6 @@ pub async fn send_http_request<T: TemplateCallback>(
     })?;
     drop(body_stream);
 
-    if let Some(task) = request_body_capture_task.take() {
-        match task.await {
-            Ok(Ok(total)) => {
-                response.request_content_length = Some(usize_to_i32(total));
-            }
-            Ok(Err(err)) => request_body_capture_error = Some(err),
-            Err(err) => request_body_capture_error = Some(err.to_string()),
-        }
-    }
-
     if let Some(err) = request_body_capture_error.take() {
         response.error = Some(append_error_message(
             response.error.take(),
@@ -828,10 +821,6 @@ pub async fn send_http_request<T: TemplateCallback>(
         ));
     }
 
-    if let Err(join_err) = event_handle.await {
-        warn!("Failed to join response event task: {}", join_err);
-    }
-
     if let Some(err) = body_read_error {
         if persist_response {
             let _ = persist_response_error(
@@ -849,6 +838,16 @@ pub async fn send_http_request<T: TemplateCallback>(
             cookie_jar.as_mut(),
             cookie_behavior.store.as_ref(),
         )?;
+        if let Some(task) = request_body_capture_task.take() {
+            match task.await {
+                Ok(Ok(_)) => {}
+                Ok(Err(err)) => warn!("Failed to store request body after response error: {err}"),
+                Err(err) => warn!("Failed to join request body capture task: {err}"),
+            }
+        }
+        if let Err(join_err) = event_handle.await {
+            warn!("Failed to join response event task: {}", join_err);
+        }
         return Err(err);
     }
 
@@ -875,6 +874,49 @@ pub async fn send_http_request<T: TemplateCallback>(
 
     persist_cookie_jar(params.query_manager, cookie_jar.as_mut(), cookie_behavior.store.as_ref())?;
 
+    // Request-body history can be much larger than the response. It should not keep the
+    // response in a loading state after the network/response-body work has completed.
+    if let Some(task) = request_body_capture_task.take() {
+        let mut update_response = false;
+        match task.await {
+            Ok(Ok(total)) => {
+                let total = Some(usize_to_i32(total));
+                if response.request_content_length != total {
+                    response.request_content_length = total;
+                    update_response = true;
+                }
+            }
+            Ok(Err(err)) => {
+                response.error = Some(append_error_message(
+                    response.error.take(),
+                    format!("Request succeeded but failed to store request body: {err}"),
+                ));
+                update_response = true;
+            }
+            Err(err) => {
+                response.error = Some(append_error_message(
+                    response.error.take(),
+                    format!("Request succeeded but failed to store request body: {err}"),
+                ));
+                update_response = true;
+            }
+        }
+
+        if update_response && persist_response {
+            response = params
+                .query_manager
+                .connect()
+                .upsert_http_response(&response, &params.update_source, params.blob_manager)
+                .map_err(SendHttpRequestError::PersistResponse)?;
+        }
+    }
+
+    // Timeline events are useful history, but they should not keep the response in a loading state
+    // after the network/response-body work has completed.
+    if let Err(join_err) = event_handle.await {
+        warn!("Failed to join response event task: {}", join_err);
+    }
+
     Ok(SendHttpRequestResult { rendered_request, response, response_body })
 }