Require screenshots confirmation in PR template

This commit is contained in:
Gregory Schier
2026-06-30 15:24:38 -07:00
parent 5229534d8f
commit 54a931d94d
2 changed files with 11 additions and 0 deletions
+1
View File
@@ -9,6 +9,7 @@
- [ ] I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md). - [ ] I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md).
- [ ] I tested this change locally. - [ ] I tested this change locally.
- [ ] I added or updated tests when reasonable. - [ ] I added or updated tests when reasonable.
- [ ] I added screenshots or recordings for UI changes when reasonable.
Explicit permission feedback item (required if not a bug fix): Explicit permission feedback item (required if not a bug fix):
@@ -60,6 +60,8 @@ const CHECKBOXES = {
"I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md).", "I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md).",
testedLocally: "I tested this change locally.", testedLocally: "I tested this change locally.",
testsUpdated: "I added or updated tests when reasonable.", testsUpdated: "I added or updated tests when reasonable.",
screenshotsAdded:
"I added screenshots or recordings for UI changes when reasonable.",
}; };
function escapeRegExp(value) { function escapeRegExp(value) {
@@ -243,6 +245,14 @@ function analyzePullRequest(pr) {
message: "Confirm that tests were added or updated when reasonable.", message: "Confirm that tests were added or updated when reasonable.",
}); });
} }
if (states.screenshotsAdded !== true) {
blockers.push({
label: LABELS.policyUnmet.name,
message:
"Confirm that screenshots or recordings were added for UI changes when reasonable.",
});
}
} }
const desiredLabels = new Set(); const desiredLabels = new Set();