diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 50c4f811..f2376d6c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,6 +9,7 @@ - [ ] I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md). - [ ] I tested this change locally. - [ ] I added or updated tests when reasonable. +- [ ] I added screenshots or recordings for UI changes when reasonable. Explicit permission feedback item (required if not a bug fix): diff --git a/.github/scripts/check-contribution-policy.js b/.github/scripts/check-contribution-policy.js index 9833bfcb..7e1a4885 100644 --- a/.github/scripts/check-contribution-policy.js +++ b/.github/scripts/check-contribution-policy.js @@ -60,6 +60,8 @@ const CHECKBOXES = { "I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md).", testedLocally: "I tested this change locally.", testsUpdated: "I added or updated tests when reasonable.", + screenshotsAdded: + "I added screenshots or recordings for UI changes when reasonable.", }; function escapeRegExp(value) { @@ -243,6 +245,14 @@ function analyzePullRequest(pr) { message: "Confirm that tests were added or updated when reasonable.", }); } + + if (states.screenshotsAdded !== true) { + blockers.push({ + label: LABELS.policyUnmet.name, + message: + "Confirm that screenshots or recordings were added for UI changes when reasonable.", + }); + } } const desiredLabels = new Set();