mirror of
https://github.com/mountain-loop/yaak.git
synced 2026-07-13 08:13:00 +02:00
Require screenshots confirmation in PR template
This commit is contained in:
@@ -9,6 +9,7 @@
|
|||||||
- [ ] I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md).
|
- [ ] I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md).
|
||||||
- [ ] I tested this change locally.
|
- [ ] I tested this change locally.
|
||||||
- [ ] I added or updated tests when reasonable.
|
- [ ] I added or updated tests when reasonable.
|
||||||
|
- [ ] I added screenshots or recordings for UI changes when reasonable.
|
||||||
|
|
||||||
Explicit permission feedback item (required if not a bug fix):
|
Explicit permission feedback item (required if not a bug fix):
|
||||||
|
|
||||||
|
|||||||
@@ -60,6 +60,8 @@ const CHECKBOXES = {
|
|||||||
"I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md).",
|
"I have read and followed [`CONTRIBUTING.md`](CONTRIBUTING.md).",
|
||||||
testedLocally: "I tested this change locally.",
|
testedLocally: "I tested this change locally.",
|
||||||
testsUpdated: "I added or updated tests when reasonable.",
|
testsUpdated: "I added or updated tests when reasonable.",
|
||||||
|
screenshotsAdded:
|
||||||
|
"I added screenshots or recordings for UI changes when reasonable.",
|
||||||
};
|
};
|
||||||
|
|
||||||
function escapeRegExp(value) {
|
function escapeRegExp(value) {
|
||||||
@@ -243,6 +245,14 @@ function analyzePullRequest(pr) {
|
|||||||
message: "Confirm that tests were added or updated when reasonable.",
|
message: "Confirm that tests were added or updated when reasonable.",
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (states.screenshotsAdded !== true) {
|
||||||
|
blockers.push({
|
||||||
|
label: LABELS.policyUnmet.name,
|
||||||
|
message:
|
||||||
|
"Confirm that screenshots or recordings were added for UI changes when reasonable.",
|
||||||
|
});
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const desiredLabels = new Set();
|
const desiredLabels = new Set();
|
||||||
|
|||||||
Reference in New Issue
Block a user