[PR #910] [MERGED] Upgrade gradle to 8.12.1 (from 8.12) and fix some build warnings #797

Closed
opened 2025-12-30 01:26:51 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/910
Author: @KushalP
Created: 1/27/2025
Status: Merged
Merged: 1/28/2025
Merged by: @bioball

Base: mainHead: gradle-8.12.1


📝 Commits (4)

  • 2e18005 Upgrade gradle to 8.12.1 (from 8.12)
  • b824ad2 Return tasks.register as tasks.create is deprecated
  • eecac7f Use property accessor .files instead of function .files()
  • 56ecbeb Return tasks.registering as tasks.creating is deprecated

📊 Changes

4 files changed (+9 additions, -9 deletions)

View changed files

📝 buildSrc/src/main/kotlin/pklGradlePluginTest.gradle.kts (+3 -3)
📝 gradle/wrapper/gradle-wrapper.properties (+2 -2)
📝 pkl-executor/pkl-executor.gradle.kts (+2 -2)
📝 pkl-tools/pkl-tools.gradle.kts (+2 -2)

📄 Description

Upgrade gradle to 8.12.1 (from 8.12)

Command used:

./gradlew wrapper \
          --gradle-version=8.12.1 \
          --gradle-distribution-sha256-sum=8d97a97984f6cbd2b85fe4c60a743440a347544bf18818048e611f5288d46c94

Release notes: https://docs.gradle.org/8.12.1/release-notes.html

Return tasks.register as tasks.create is deprecated

Fixes the following warning:

buildSrc/src/main/kotlin/pklGradlePluginTest.gradle.kts:94:16 'create(String, Class<T!>, Action<in T!>): T' is deprecated. Deprecated in Java

Use property accessor .files instead of function .files()

Fixes warning:

pkl-executor/pkl-executor.gradle.kts:71:45: 'files(vararg Dependency!): (Mutable)Set<File!>!' is deprecated. Deprecated in Java

Return tasks.registering as tasks.creating is deprecated

Fixes the following warning:

pkl-tools/pkl-tools.gradle.kts:55:27: 'creating(KClass<U>, U.() -> Unit): PolymorphicDomainObjectContainerCreatingDelegateProvider<Task!, U>' is deprecated. Use registering instead. See https://docs.gradle.org/current/userguide/task_configuration_avoidance.html for more information.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/910 **Author:** [@KushalP](https://github.com/KushalP) **Created:** 1/27/2025 **Status:** ✅ Merged **Merged:** 1/28/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `gradle-8.12.1` --- ### 📝 Commits (4) - [`2e18005`](https://github.com/apple/pkl/commit/2e18005380c23ca3cb4c1bd1c0c6b202c0405b2d) Upgrade `gradle` to `8.12.1` (from `8.12`) - [`b824ad2`](https://github.com/apple/pkl/commit/b824ad25e300a377789d38e0e80a7773351c8ab3) Return `tasks.register` as `tasks.create` is deprecated - [`eecac7f`](https://github.com/apple/pkl/commit/eecac7fb4bc7164f8d1ad75e6cf912f8451bd440) Use property accessor `.files` instead of function `.files()` - [`56ecbeb`](https://github.com/apple/pkl/commit/56ecbebc01432e3ce561a86b9adcfe2840fc83b5) Return `tasks.registering` as `tasks.creating` is deprecated ### 📊 Changes **4 files changed** (+9 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `buildSrc/src/main/kotlin/pklGradlePluginTest.gradle.kts` (+3 -3) 📝 `gradle/wrapper/gradle-wrapper.properties` (+2 -2) 📝 `pkl-executor/pkl-executor.gradle.kts` (+2 -2) 📝 `pkl-tools/pkl-tools.gradle.kts` (+2 -2) </details> ### 📄 Description ### Upgrade gradle to 8.12.1 (from 8.12) Command used: ``` ./gradlew wrapper \ --gradle-version=8.12.1 \ --gradle-distribution-sha256-sum=8d97a97984f6cbd2b85fe4c60a743440a347544bf18818048e611f5288d46c94 ``` Release notes: https://docs.gradle.org/8.12.1/release-notes.html ### Return tasks.register as tasks.create is deprecated Fixes the following warning: ``` buildSrc/src/main/kotlin/pklGradlePluginTest.gradle.kts:94:16 'create(String, Class<T!>, Action<in T!>): T' is deprecated. Deprecated in Java ``` ### Use property accessor .files instead of function .files() Fixes warning: ``` pkl-executor/pkl-executor.gradle.kts:71:45: 'files(vararg Dependency!): (Mutable)Set<File!>!' is deprecated. Deprecated in Java ``` ### Return `tasks.registering` as `tasks.creating` is deprecated Fixes the following warning: ``` pkl-tools/pkl-tools.gradle.kts:55:27: 'creating(KClass<U>, U.() -> Unit): PolymorphicDomainObjectContainerCreatingDelegateProvider<Task!, U>' is deprecated. Use registering instead. See https://docs.gradle.org/current/userguide/task_configuration_avoidance.html for more information. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:51 +01:00
adam closed this issue 2025-12-30 01:26:52 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#797