starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1138] [MERGED] Un-deprecate Resource.base64, compute bytes/base64 in terms of each other #910

New Issue
Closed
opened 2025-12-30 01:27:42 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:27:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1138
Author: @bioball
Created: 7/23/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @bioball

Base: main ← Head: resource-fix

📝 Commits (3)

  • d633c8b Un-deprecate Resource.base64, compute bytes/base64 in terms of each other
  • 32461cb Update Resource.pkl
  • 465b0e6 Fix test

📊 Changes

12 files changed (+270 additions, -227 deletions)

View changed files

📝 pkl-core/src/test/files/LanguageSnippetTests/input/api/Resource.pkl (+24 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/Resource.pcf (+17 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/reflectedDeclaration.pcf (+162 -162)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/basic/read.pcf (+8 -8)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/basic/readGlob.pcf (+22 -22)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/packages/packages1.pcf (+3 -3)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/packages/packages2.pcf (+5 -5)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/projects/project1/basic.pcf (+2 -2)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/projects/project1/globbing.pcf (+15 -15)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/projects/project1/localProjectRead.pcf (+3 -3)
📝 pkl-server/src/test/kotlin/org/pkl/server/AbstractServerTest.kt (+2 -2)
📝 stdlib/base.pkl (+7 -5)

📄 Description

This makes changes to avoid a needless breaking change. It preserves code like new Resource { base64 = someValue }.sha256, and also code that renders Resource into static formats.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1138 **Author:** [@bioball](https://github.com/bioball) **Created:** 7/23/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `resource-fix` --- ### 📝 Commits (3) - [`d633c8b`](https://github.com/apple/pkl/commit/d633c8b71302da981084e8d0c04b906d95ac1d06) Un-deprecate Resource.base64, compute bytes/base64 in terms of each other - [`32461cb`](https://github.com/apple/pkl/commit/32461cbb0d66f5e159c579460ad4da3041ec975b) Update Resource.pkl - [`465b0e6`](https://github.com/apple/pkl/commit/465b0e68b23accf872522b2967e590492e3cb8e8) Fix test ### 📊 Changes **12 files changed** (+270 additions, -227 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/api/Resource.pkl` (+24 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/Resource.pcf` (+17 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/reflectedDeclaration.pcf` (+162 -162) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/basic/read.pcf` (+8 -8) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/basic/readGlob.pcf` (+22 -22) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/packages/packages1.pcf` (+3 -3) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/packages/packages2.pcf` (+5 -5) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/projects/project1/basic.pcf` (+2 -2) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/projects/project1/globbing.pcf` (+15 -15) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/projects/project1/localProjectRead.pcf` (+3 -3) 📝 `pkl-server/src/test/kotlin/org/pkl/server/AbstractServerTest.kt` (+2 -2) 📝 `stdlib/base.pkl` (+7 -5) </details> ### 📄 Description This makes changes to avoid a needless breaking change. It preserves code like `new Resource { base64 = someValue }.sha256`, and also code that renders `Resource` into static formats. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:42 +01:00
adam closed this issue 2025-12-30 01:27:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#910
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?