[PR #885] [CLOSED] Use GitHub Actions for checks #789

New Issue

adam · 2025-12-30T01:26:47+01:00

adam commented

2025-12-30 01:26:47 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/885
Author: @StefMa
Created: 1/15/2025
Status: ❌ Closed

Base: main ← Head: github-action-prs

📝 Commits (3)

6114373 Add pkl workflows for GitHub Action
9d6888b Translate pkl actions
4b9994e Demonstrate GitHub Action Run

📊 Changes

4 files changed (+161 additions, -0 deletions)

View changed files

➕ .github/pkl-workflows/CheckActionsConverted.pkl (+37 -0)
➕ .github/pkl-workflows/Checks.pkl (+63 -0)
➕ .github/workflows/CheckActionsConverted.generated.yml (+21 -0)
➕ .github/workflows/Checks.generated.yml (+40 -0)

📄 Description

Hello everyone ✌️

this PR might fix #152 and therefore also contributes to #225.

Two reasons why this would be a step forward:

Forks can simply check in their own repo if something isn't broken. Right now they have to check stuff locally and we all know this might not happen all the time 😅
PRs, depending on the setting, can run automatically run checks without an approval.
Since this is the "start" of using GitHub actions, we can also start implemeting #225 as dependabot would also run on actions and we can create workflows that "do something after they run" or after "dependabot created a PR"... See https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions
???

I just converted the checks from the circleci config for now because

I wanted to hear your opinion about this first (generally)
What do you think about using my pkl-gha project 🙃
Other comments 🙃
Le me know if this is "fine" or if I also convert all the other jobs.
On the other side we can also do this as follow-ups in other PRs.
Let me know what you prefer.

Because using a matrix is super easy to setup on actions, I also decided to run jdk 21 on windows 🤷
This isn't in the circleci config but doesn't hurt i guess?!

If you want to see how this looks like in action, checkout this run on my fork:

TODO before merge:

Remove demosntrate github action run

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/885 **Author:** [@StefMa](https://github.com/StefMa) **Created:** 1/15/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `github-action-prs` --- ### 📝 Commits (3) - [`6114373`](https://github.com/apple/pkl/commit/61143739965721ba7035a09ac2210f889e212d6a) Add pkl workflows for GitHub Action - [`9d6888b`](https://github.com/apple/pkl/commit/9d6888b16a6a469814b559b1bbaabc1baead34f3) Translate pkl actions - [`4b9994e`](https://github.com/apple/pkl/commit/4b9994e53dbfc26dbef012755860c0063cf865fd) Demonstrate GitHub Action Run ### 📊 Changes **4 files changed** (+161 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `.github/pkl-workflows/CheckActionsConverted.pkl` (+37 -0) ➕ `.github/pkl-workflows/Checks.pkl` (+63 -0) ➕ `.github/workflows/CheckActionsConverted.generated.yml` (+21 -0) ➕ `.github/workflows/Checks.generated.yml` (+40 -0) </details> ### 📄 Description Hello everyone ✌️ this PR might fix #152 and therefore also contributes to #225. Two reasons why this would be a step forward: * Forks can simply check in their own repo if something isn't broken. Right now they have to check stuff locally and we all know this might not happen all the time 😅 * PRs, depending on the [setting](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories), can run automatically run checks without an approval. * Since this is the "start" of using GitHub actions, we can also start implemeting #225 as dependabot would also run on actions and we can create workflows that "do something after they run" or after "dependabot created a PR"... See https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions * ??? I just converted the `checks` from the circleci config for now because 1. I wanted to hear your opinion about this first (generally) 2. What do you think about using my pkl-gha project 🙃 3. Other comments 🙃 Le me know if this is "fine" or if I also convert all the other jobs. On the other side we can also do this as follow-ups in other PRs. Let me know what you prefer. Because using a matrix is super easy to setup on actions, I also decided to run jdk 21 on windows 🤷 This isn't in the circleci config but doesn't hurt i guess?! If you want to see how this looks like in action, checkout this run on my fork: * [Check Pkl Actions Converted](https://github.com/StefMa/pkl/actions/runs/12783766972) * [Checks](https://github.com/StefMa/pkl/actions/runs/12783766976) ## TODO before merge: - [ ] Remove demosntrate github action run --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:47 +01:00

adam closed this issue

2025-12-30 01:26:48 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#789