[PR #1086] [MERGED] Fix multi-jdk testing setup #885

New Issue

adam · 2025-12-30T01:27:33+01:00

adam commented

2025-12-30 01:27:33 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1086
Author: @bioball
Created: 6/2/2025
Status: ✅ Merged
Merged: 6/3/2025
Merged by: @bioball

Base: main ← Head: multi-jdk-testing-fix

📝 Commits (1)

5889666 Fix multi-jdk testing setup

📊 Changes

5 files changed (+21 additions, -25 deletions)

View changed files

📝 buildSrc/src/main/kotlin/BuildInfo.kt (+15 -15)
📝 buildSrc/src/main/kotlin/pklJavaExecutable.gradle.kts (+2 -3)
📝 buildSrc/src/main/kotlin/pklJavaLibrary.gradle.kts (+2 -1)
📝 pkl-cli/pkl-cli.gradle.kts (+1 -6)
📝 pkl-tools/pkl-tools.gradle.kts (+1 -0)

📄 Description

This changes the Gradle build to always create multi-jdk tasks, and instead use the enabled property to determine whether the task is actually ran or not.

The has the following benefits:

IntelliJ and other tools understand the task execution graph (e.g. testJdk20 shows up as a task)
gw updateDependencyLocks discovers all configurations

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1086 **Author:** [@bioball](https://github.com/bioball) **Created:** 6/2/2025 **Status:** ✅ Merged **Merged:** 6/3/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `multi-jdk-testing-fix` --- ### 📝 Commits (1) - [`5889666`](https://github.com/apple/pkl/commit/58896669b2532ff6d8ff086486a7cfe43addc2f3) Fix multi-jdk testing setup ### 📊 Changes **5 files changed** (+21 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `buildSrc/src/main/kotlin/BuildInfo.kt` (+15 -15) 📝 `buildSrc/src/main/kotlin/pklJavaExecutable.gradle.kts` (+2 -3) 📝 `buildSrc/src/main/kotlin/pklJavaLibrary.gradle.kts` (+2 -1) 📝 `pkl-cli/pkl-cli.gradle.kts` (+1 -6) 📝 `pkl-tools/pkl-tools.gradle.kts` (+1 -0) </details> ### 📄 Description This changes the Gradle build to always create multi-jdk tasks, and instead use the `enabled` property to determine whether the task is actually ran or not. The has the following benefits: * IntelliJ and other tools understand the task execution graph (e.g. testJdk20 shows up as a task) * `gw updateDependencyLocks` discovers all configurations --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:33 +01:00

adam closed this issue

2025-12-30 01:27:34 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#885