starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 23:23:37 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #830] [CLOSED] fix regression where typealiases are not executed in their original context #764

New Issue
Closed
opened 2025-12-30 01:26:36 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:36 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/830
Author: @stackoverflow
Created: 11/27/2024
Status: ❌ Closed

Base: main ← Head: fix-typealias-scope

📝 Commits (2)

  • 2fb7b77 fix regression where typealiases are not executed in their original context
  • 8712d4f fix review remark

📊 Changes

7 files changed (+166 additions, -9 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/member/ListingOrMappingTypeCastNode.java (+30 -1)
📝 pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java (+100 -8)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/types/helpers/originalTypealias.pkl (+5 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAlias1.pkl (+7 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAliasContext.pkl (+3 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAlias1.pcf (+6 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAliasContext.err (+15 -0)

📄 Description

Closes #823

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/830 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 11/27/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-typealias-scope` --- ### 📝 Commits (2) - [`2fb7b77`](https://github.com/apple/pkl/commit/2fb7b77621ef4795e677a5a4d0d37a9b04a8a576) fix regression where typealiases are not executed in their original context - [`8712d4f`](https://github.com/apple/pkl/commit/8712d4f6162f2d88354c5d7e8114127a8fa85b2f) fix review remark ### 📊 Changes **7 files changed** (+166 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/member/ListingOrMappingTypeCastNode.java` (+30 -1) 📝 `pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java` (+100 -8) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/types/helpers/originalTypealias.pkl` (+5 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAlias1.pkl` (+7 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/types/typeAliasContext.pkl` (+3 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAlias1.pcf` (+6 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/types/typeAliasContext.err` (+15 -0) </details> ### 📄 Description Closes #823 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:36 +01:00
adam closed this issue 2025-12-30 01:26:36 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#764
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?