[PR #962] [MERGED] move handling of strings to parser #830

New Issue

adam · 2025-12-30T01:27:04+01:00

adam commented

2025-12-30 01:27:04 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/962
Author: @stackoverflow
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/19/2025
Merged by: @stackoverflow

Base: main ← Head: move-string-logic-to-parser

📝 Commits (2)

143cbae move handling of strings to parser
2563554 fix review remarks

📊 Changes

25 files changed (+408 additions, -543 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/builder/AbstractAstBuilder.java (+0 -65)
📝 pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java (+10 -170)
📝 pkl-core/src/main/java/org/pkl/core/ast/builder/ImportsAndReadsParser.java (+8 -14)
📝 pkl-core/src/main/java/org/pkl/core/parser/BaseParserVisitor.java (+0 -6)
📝 pkl-core/src/main/java/org/pkl/core/parser/Parser.java (+279 -84)
📝 pkl-core/src/main/java/org/pkl/core/parser/ParserVisitor.java (+0 -3)
📝 pkl-core/src/main/java/org/pkl/core/parser/Span.java (+4 -0)
📝 pkl-core/src/main/java/org/pkl/core/parser/ast/StringConstant.java (+34 -7)
➖ pkl-core/src/main/java/org/pkl/core/parser/ast/StringConstantPart.java (+0 -156)
📝 pkl-core/src/main/java/org/pkl/core/parser/ast/StringPart.java (+35 -7)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/delimiters/missingEmptyMultiLineStringDelimiter.err (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/delimiters/missingEmptyMultiLineStringDelimiterAtEof.err (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/delimiters/missingEmptyStringDelimiterAtEof.err (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/delimiters/missingMultiLineStringDelimiter.err (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/delimiters/missingRawMultiLineStringDelimiter.err (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/invalidUnicodeEscape.err (+3 -3)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser3.err (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser4.err (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser6.err (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser8.err (+1 -1)

...and 5 more files

📄 Description

The parser now makes sure that all strings are syntactically valid.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/962 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/19/2025 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `move-string-logic-to-parser` --- ### 📝 Commits (2) - [`143cbae`](https://github.com/apple/pkl/commit/143cbae52885a5a084040bb700c95d34cccef0b0) move handling of strings to parser - [`2563554`](https://github.com/apple/pkl/commit/256355437b81680ded9dcf1c14da5592d2a27a6e) fix review remarks ### 📊 Changes **25 files changed** (+408 additions, -543 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/AbstractAstBuilder.java` (+0 -65) 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java` (+10 -170) 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/ImportsAndReadsParser.java` (+8 -14) 📝 `pkl-core/src/main/java/org/pkl/core/parser/BaseParserVisitor.java` (+0 -6) 📝 `pkl-core/src/main/java/org/pkl/core/parser/Parser.java` (+279 -84) 📝 `pkl-core/src/main/java/org/pkl/core/parser/ParserVisitor.java` (+0 -3) 📝 `pkl-core/src/main/java/org/pkl/core/parser/Span.java` (+4 -0) 📝 `pkl-core/src/main/java/org/pkl/core/parser/ast/StringConstant.java` (+34 -7) ➖ `pkl-core/src/main/java/org/pkl/core/parser/ast/StringConstantPart.java` (+0 -156) 📝 `pkl-core/src/main/java/org/pkl/core/parser/ast/StringPart.java` (+35 -7) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/delimiters/missingEmptyMultiLineStringDelimiter.err` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/delimiters/missingEmptyMultiLineStringDelimiterAtEof.err` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/delimiters/missingEmptyStringDelimiterAtEof.err` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/delimiters/missingMultiLineStringDelimiter.err` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/delimiters/missingRawMultiLineStringDelimiter.err` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/invalidUnicodeEscape.err` (+3 -3) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser3.err` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser4.err` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser6.err` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/parser8.err` (+1 -1) _...and 5 more files_ </details> ### 📄 Description The parser now makes sure that all strings are syntactically valid. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:04 +01:00

adam closed this issue

2025-12-30 01:27:04 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#830