[PR #764] [CLOSED] Make msgpack-java an optional dependency #720

New Issue

adam · 2025-12-30T01:26:22+01:00

adam commented

2025-12-30 01:26:22 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/764
Author: @bioball
Created: 11/1/2024
Status: ❌ Closed

Base: main ← Head: optional-msgpack-dependency

📝 Commits (1)

2484186 Make msgpack-java an optional dependency

📊 Changes

19 files changed (+106 additions, -56 deletions)

View changed files

📝 bench/gradle.lockfile (+0 -1)
📝 buildSrc/src/main/kotlin/pklFatJar.gradle.kts (+1 -1)
📝 docs/gradle.lockfile (+0 -1)
📝 pkl-cli/gradle.lockfile (+8 -4)
📝 pkl-codegen-java/gradle.lockfile (+8 -5)
📝 pkl-codegen-kotlin/gradle.lockfile (+8 -5)
📝 pkl-commons-cli/gradle.lockfile (+8 -5)
📝 pkl-config-java/gradle.lockfile (+10 -6)
📝 pkl-config-java/pkl-config-java.gradle.kts (+3 -0)
📝 pkl-config-kotlin/gradle.lockfile (+10 -6)
📝 pkl-core/gradle.lockfile (+1 -1)
📝 pkl-core/pkl-core.gradle.kts (+3 -1)
📝 pkl-core/src/main/java/org/pkl/core/module/ModuleKeyFactories.java (+12 -3)
📝 pkl-core/src/main/java/org/pkl/core/resource/ResourceReaders.java (+8 -0)
📝 pkl-doc/gradle.lockfile (+8 -5)
📝 pkl-executor/gradle.lockfile (+2 -2)
📝 pkl-gradle/gradle.lockfile (+8 -4)
📝 pkl-tools/gradle.lockfile (+6 -6)
📝 pkl-tools/pkl-tools.gradle.kts (+2 -0)

📄 Description

Make msgpack-java a compileTime dependency in pkl-core, and include it:

In the fat jars (pkl-config-java-all, pkl-conifg-java)
In the CLIs

The is the alternative to https://github.com/apple/pkl/pull/763

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/764 **Author:** [@bioball](https://github.com/bioball) **Created:** 11/1/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `optional-msgpack-dependency` --- ### 📝 Commits (1) - [`2484186`](https://github.com/apple/pkl/commit/248418635ae14124f4af8723632a5eda1d7bb0cd) Make msgpack-java an optional dependency ### 📊 Changes **19 files changed** (+106 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `bench/gradle.lockfile` (+0 -1) 📝 `buildSrc/src/main/kotlin/pklFatJar.gradle.kts` (+1 -1) 📝 `docs/gradle.lockfile` (+0 -1) 📝 `pkl-cli/gradle.lockfile` (+8 -4) 📝 `pkl-codegen-java/gradle.lockfile` (+8 -5) 📝 `pkl-codegen-kotlin/gradle.lockfile` (+8 -5) 📝 `pkl-commons-cli/gradle.lockfile` (+8 -5) 📝 `pkl-config-java/gradle.lockfile` (+10 -6) 📝 `pkl-config-java/pkl-config-java.gradle.kts` (+3 -0) 📝 `pkl-config-kotlin/gradle.lockfile` (+10 -6) 📝 `pkl-core/gradle.lockfile` (+1 -1) 📝 `pkl-core/pkl-core.gradle.kts` (+3 -1) 📝 `pkl-core/src/main/java/org/pkl/core/module/ModuleKeyFactories.java` (+12 -3) 📝 `pkl-core/src/main/java/org/pkl/core/resource/ResourceReaders.java` (+8 -0) 📝 `pkl-doc/gradle.lockfile` (+8 -5) 📝 `pkl-executor/gradle.lockfile` (+2 -2) 📝 `pkl-gradle/gradle.lockfile` (+8 -4) 📝 `pkl-tools/gradle.lockfile` (+6 -6) 📝 `pkl-tools/pkl-tools.gradle.kts` (+2 -0) </details> ### 📄 Description Make msgpack-java a compileTime dependency in pkl-core, and include it: * In the fat jars (pkl-config-java-all, pkl-conifg-java) * In the CLIs The is the alternative to https://github.com/apple/pkl/pull/763 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:22 +01:00

adam closed this issue

2025-12-30 01:26:22 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#720