starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #731] [MERGED] Cyclical dependencies report #698

New Issue
Closed
opened 2025-12-30 01:26:13 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:13 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/731
Author: @stackoverflow
Created: 10/23/2024
Status: ✅ Merged
Merged: 10/25/2024
Merged by: @bioball

Base: main ← Head: cyclical-dependencies-report

📝 Commits (10+)

📊 Changes

10 files changed (+377 additions, -11 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/project/Project.java (+100 -11)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmExceptionRenderer.java (+4 -0)
➕ pkl-core/src/main/java/org/pkl/core/util/ImportGraphUtils.java (+64 -0)
📝 pkl-core/src/main/resources/org/pkl/core/errorMessages.properties (+15 -0)
📝 pkl-core/src/test/kotlin/org/pkl/core/project/ProjectTest.kt (+56 -0)
➕ pkl-core/src/test/kotlin/org/pkl/core/util/ImportGraphUtilsTest.kt (+95 -0)
➕ pkl-core/src/test/resources/org/pkl/core/project/projectCycle1/PklProject (+12 -0)
➕ pkl-core/src/test/resources/org/pkl/core/project/projectCycle2/PklProject (+12 -0)
➕ pkl-core/src/test/resources/org/pkl/core/project/projectCycle3/PklProject (+12 -0)
➕ pkl-core/src/test/resources/org/pkl/core/project/projectCycle4/PklProject (+7 -0)

📄 Description

This is based on @bioball's import graph PR.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/731 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 10/23/2024 **Status:** ✅ Merged **Merged:** 10/25/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `cyclical-dependencies-report` --- ### 📝 Commits (10+) - [`c96d0c1`](https://github.com/apple/pkl/commit/c96d0c1313a42ec9aa6099ae5856b478ded6d5d5) Add import analyzer - [`db5c9e6`](https://github.com/apple/pkl/commit/db5c9e611fc4394377e1665941c131759577dafb) Add Gradle support for analyze - [`6e3b31d`](https://github.com/apple/pkl/commit/6e3b31d4cba95bfcc8c4ff5b839ff03639d8e645) Updates - [`ea03e0b`](https://github.com/apple/pkl/commit/ea03e0b501270f887592ec2eb944f0f008011d23) Updates - [`46410cf`](https://github.com/apple/pkl/commit/46410cfd95e34964609ac9f1c800dddd62629121) Move class Import below ImportGraph - [`f7d2004`](https://github.com/apple/pkl/commit/f7d2004572810891e6588093ac94d714a7a88b7b) report on cyclical dependencies - [`7481956`](https://github.com/apple/pkl/commit/74819562763921a34f09ccae23bf36c8ac78238a) report cycles in dependencies - [`1a358a3`](https://github.com/apple/pkl/commit/1a358a3eab64ab348ee77736586fd03aa5edb4da) revert change - [`01aa064`](https://github.com/apple/pkl/commit/01aa064aa996a96c9aae97d0b693f2736d67454d) improve cycle detection - [`3b07cd8`](https://github.com/apple/pkl/commit/3b07cd889b5091783dfcba2381900c527b3c9f89) Add tests for cycle detection; improve error message ### 📊 Changes **10 files changed** (+377 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/project/Project.java` (+100 -11) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmExceptionRenderer.java` (+4 -0) ➕ `pkl-core/src/main/java/org/pkl/core/util/ImportGraphUtils.java` (+64 -0) 📝 `pkl-core/src/main/resources/org/pkl/core/errorMessages.properties` (+15 -0) 📝 `pkl-core/src/test/kotlin/org/pkl/core/project/ProjectTest.kt` (+56 -0) ➕ `pkl-core/src/test/kotlin/org/pkl/core/util/ImportGraphUtilsTest.kt` (+95 -0) ➕ `pkl-core/src/test/resources/org/pkl/core/project/projectCycle1/PklProject` (+12 -0) ➕ `pkl-core/src/test/resources/org/pkl/core/project/projectCycle2/PklProject` (+12 -0) ➕ `pkl-core/src/test/resources/org/pkl/core/project/projectCycle3/PklProject` (+12 -0) ➕ `pkl-core/src/test/resources/org/pkl/core/project/projectCycle4/PklProject` (+7 -0) </details> ### 📄 Description This is based on @bioball's import graph PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:13 +01:00
adam closed this issue 2025-12-30 01:26:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#698
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?