starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #781] [MERGED] Fix equals/hashCode/hasCachedValue in delegating listings/mappings #731

New Issue
Closed
opened 2025-12-30 01:26:25 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/781
Author: @bioball
Created: 11/5/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @bioball

Base: main ← Head: fix-equals-hashcode

📝 Commits (4)

  • 64c286f Fix equals/hashCode in listings/mappings
  • f4f196c Add fix for hasCachedValue
  • 590a4f3 Avoid unnecessary cast
  • 7040837 Apply suggestions from code review

📊 Changes

14 files changed (+170 additions, -57 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/runtime/VmListing.java (+8 -14)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmListingOrMapping.java (+6 -1)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmMapping.java (+16 -41)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmObject.java (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/api/mapping.pkl (+8 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/listings/equality.pkl (+11 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/listings/hashCode.pkl (+32 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/mappings/equality.pkl (+11 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/mappings/hashCode.pkl (+30 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/mapping.pcf (+1 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/listings/equality.pcf (+1 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/listings/hashCode.pcf (+22 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/mappings/equality.pcf (+1 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/mappings/hashCode.pcf (+22 -0)

📄 Description

This fixes issues when a mapping/listing delegates to another mapping/listing.

The core issue is that cachedValues is not guaranteed to be the complete set of the object's members; they may be stored on the delegate instead.

Therefore, it's not correct compute hash code and equality based on cachedValues. Instead, it's better to use the getCachedValue() method, which has the correct logic for looking up the existing cached value.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/781 **Author:** [@bioball](https://github.com/bioball) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-equals-hashcode` --- ### 📝 Commits (4) - [`64c286f`](https://github.com/apple/pkl/commit/64c286f0fe178af232b961df4dd2aafbec83d7de) Fix equals/hashCode in listings/mappings - [`f4f196c`](https://github.com/apple/pkl/commit/f4f196cd009b054c142a3592324ea5377e7ae76b) Add fix for hasCachedValue - [`590a4f3`](https://github.com/apple/pkl/commit/590a4f3436052fdfdb0da1850d82aed7422a6aa7) Avoid unnecessary cast - [`7040837`](https://github.com/apple/pkl/commit/70408373c05e6809fedf3f0bba01a5a6ad0fedcb) Apply suggestions from code review ### 📊 Changes **14 files changed** (+170 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmListing.java` (+8 -14) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmListingOrMapping.java` (+6 -1) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmMapping.java` (+16 -41) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmObject.java` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/api/mapping.pkl` (+8 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/listings/equality.pkl` (+11 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/listings/hashCode.pkl` (+32 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/mappings/equality.pkl` (+11 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/mappings/hashCode.pkl` (+30 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/mapping.pcf` (+1 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/listings/equality.pcf` (+1 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/listings/hashCode.pcf` (+22 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/mappings/equality.pcf` (+1 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/mappings/hashCode.pcf` (+22 -0) </details> ### 📄 Description This fixes issues when a mapping/listing delegates to another mapping/listing. The core issue is that `cachedValues` is not guaranteed to be the complete set of the object's members; they may be stored on the delegate instead. Therefore, it's not correct compute hash code and equality based on `cachedValues`. Instead, it's better to use the `getCachedValue()` method, which has the correct logic for looking up the existing cached value. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:25 +01:00
adam closed this issue 2025-12-30 01:26:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#731
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?