[PR #678] [MERGED] Add support for const object members #665

New Issue

Closed

opened 2025-12-30 01:26:02 +01:00 by adam · 0 comments

adam commented 2025-12-30 01:26:02 +01:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/678
Author: @bioball
Created: 10/11/2024
Status: ✅ Merged
Merged: 10/22/2024
Merged by: @bioball

Base: main ← Head: const-object-members

---

📝 Commits (2)

• b6749b1 Add support for const object members
• d308fdf Add one more test case

📊 Changes

13 files changed (+104 additions, -5 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/VmModifier.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java (+13 -3)
📝 pkl-core/src/main/resources/org/pkl/core/errorMessages.properties (+3 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input-helper/modules/Birds2.pkl (+5 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/basic/constModifier4.pkl (+15 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/errors/const/constLocalAmendModule.pkl (+9 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/errors/const/constLocalMethod.pkl (+7 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/errors/const/constLocalProperty.pkl (+5 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/basic/constModifier4.pcf (+6 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/errors/const/constLocalAmendModule.pcf (+3 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/errors/const/constLocalMethod.err (+18 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/errors/const/constLocalProperty.err (+18 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/const/constObjectMember.err (+1 -1)

📄 Description

Follows SPICE-0011

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/678 **Author:** [@bioball](https://github.com/bioball) **Created:** 10/11/2024 **Status:** ✅ Merged **Merged:** 10/22/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `const-object-members` --- ### 📝 Commits (2) - [`b6749b1`](https://github.com/apple/pkl/commit/b6749b1374222d4aae856f6f2fcf0de3f9143ab0) Add support for const object members - [`d308fdf`](https://github.com/apple/pkl/commit/d308fdfda737b6a9ecbdf9feab0ab811a164d2e3) Add one more test case ### 📊 Changes **13 files changed** (+104 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/VmModifier.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java` (+13 -3) 📝 `pkl-core/src/main/resources/org/pkl/core/errorMessages.properties` (+3 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input-helper/modules/Birds2.pkl` (+5 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/basic/constModifier4.pkl` (+15 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/const/constLocalAmendModule.pkl` (+9 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/const/constLocalMethod.pkl` (+7 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/const/constLocalProperty.pkl` (+5 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/basic/constModifier4.pcf` (+6 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/errors/const/constLocalAmendModule.pcf` (+3 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/errors/const/constLocalMethod.err` (+18 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/errors/const/constLocalProperty.err` (+18 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/const/constObjectMember.err` (+1 -1) </details> ### 📄 Description Follows [SPICE-0011](https://github.com/apple/pkl-evolution/pull/12) --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-30 01:26:02 +01:00

adam closed this issue 2025-12-30 01:26:02 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

release/0.30

srueg/run-format-apply

srueg/format-multiple

srueg/formatter-test-cases

release/0.29

release/0.28

release/0.27

release/0.26

release/0.25

0.30.2

0.30.1

0.30.0

0.29.1

0.29.0

0.28.2

0.28.1

0.28.0

0.27.2

0.27.1

0.27.0

0.26.3

0.26.2

0.26.1

0.26.0

0.25.3

0.25.2

0.25.1

0.25.0

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

pull-request

Mirrored from GitHub Pull Request

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#665