starred/pkl
1
0 Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-11-13 12:23:51 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #696] [MERGED] Fix handling of file: module URIs with non-ASCII characters #678

New Issue
Closed
opened 2025-12-30 01:26:06 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:06 +01:00
Owner
Copy link
Copy source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/696
Author: @HT154
Created: 10/16/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @bioball

Base: main ← Head: nihongjouzu

📝 Commits (7)

  • d91e9b5 Fix handling of file: module URIs with non-ASCII characters
  • 0a2c4d6 Refactor to IoUtils; Cover FileResolver, StackFrameTransformer; more tests
  • f8605ec Hopefully fix windows support
  • eabb9d2 pathOfURI -> pathOf
  • a890dd9 Exclude test on windows; format string
  • 2e86f77 Fix regex
  • 7f538c5 Fix test

📊 Changes

10 files changed (+121 additions, -9 deletions)

View changed files

📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt (+56 -0)
📝 pkl-core/src/main/java/org/pkl/core/StackFrameTransformers.java (+1 -2)
📝 pkl-core/src/main/java/org/pkl/core/module/FileResolver.java (+3 -2)
📝 pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java (+1 -3)
📝 pkl-core/src/main/java/org/pkl/core/util/IoUtils.java (+14 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/modules/日本語.pkl (+6 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/modules/日本語_error.pkl (+2 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/modules/日本語.pcf (+21 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/modules/日本語_error.err (+10 -0)
📝 pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt (+7 -2)

📄 Description

Resolves #653

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/696 **Author:** [@HT154](https://github.com/HT154) **Created:** 10/16/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `nihongjouzu` --- ### 📝 Commits (7) - [`d91e9b5`](https://github.com/apple/pkl/commit/d91e9b5dfd9aa106afdca89e3479155c39e188be) Fix handling of file: module URIs with non-ASCII characters - [`0a2c4d6`](https://github.com/apple/pkl/commit/0a2c4d6f6ebe3ff65ea20a6c589b7bf1c54a3aaf) Refactor to IoUtils; Cover FileResolver, StackFrameTransformer; more tests - [`f8605ec`](https://github.com/apple/pkl/commit/f8605ec496370b0f2fed9dbd6441529a193e51d0) Hopefully fix windows support - [`eabb9d2`](https://github.com/apple/pkl/commit/eabb9d2b4d0d505900f7edcd3c9c8023ff4907d0) pathOfURI -> pathOf - [`a890dd9`](https://github.com/apple/pkl/commit/a890dd91668473cca46663e97525c9ac1ff13ec4) Exclude test on windows; format string - [`2e86f77`](https://github.com/apple/pkl/commit/2e86f77344931fe00bef118a1033f8e0e6135921) Fix regex - [`7f538c5`](https://github.com/apple/pkl/commit/7f538c5c771886cabcf08b2649445622aa0c6dcb) Fix test ### 📊 Changes **10 files changed** (+121 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt` (+56 -0) 📝 `pkl-core/src/main/java/org/pkl/core/StackFrameTransformers.java` (+1 -2) 📝 `pkl-core/src/main/java/org/pkl/core/module/FileResolver.java` (+3 -2) 📝 `pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java` (+1 -3) 📝 `pkl-core/src/main/java/org/pkl/core/util/IoUtils.java` (+14 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/modules/日本語.pkl` (+6 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/modules/日本語_error.pkl` (+2 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/modules/日本語.pcf` (+21 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/modules/日本語_error.err` (+10 -0) 📝 `pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt` (+7 -2) </details> ### 📄 Description Resolves #653 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:06 +01:00
adam closed this issue 2025-12-30 01:26:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#678