starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 23:23:37 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #660] [MERGED] Implement SPICE-0009 External Readers #661

New Issue
Closed
opened 2025-12-30 01:26:00 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/660
Author: @HT154
Created: 9/23/2024
Status: ✅ Merged
Merged: 10/29/2024
Merged by: @bioball

Base: main ← Head: external-readers

📝 Commits (10+)

  • 426237a Refactor message-passing logic into pkl-core
  • dd29012 Split server-specific messages/encoding/decoding back into pkl-server
  • d27908b Implement SPICE-0009 External Readers
  • 472b89d docs
  • 42ce6f0 Add ExternalReaderRuntime, lots of test coverage
  • 4f5a72d Add doc comments to new public APIs
  • b50f801 Improve backcompat for new language binding libs on old pkl versions
  • b5b6a59 Apply suggestions from code review
  • ff3f1e0 Address review feedback
  • d772e5c Use records for message types

📊 Changes

110 files changed (+4363 additions, -1805 deletions)

View changed files

📝 bench/gradle.lockfile (+1 -0)
📝 docs/gradle.lockfile (+1 -0)
📝 docs/modules/bindings-specification/pages/message-passing-api.adoc (+95 -2)
📝 docs/modules/language-reference/pages/index.adoc (+67 -1)
📝 docs/src/test/kotlin/DocSnippetTests.kt (+1 -1)
📝 pkl-cli/gradle.lockfile (+1 -1)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt (+3 -2)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliImportAnalyzer.kt (+3 -2)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliServer.kt (+2 -3)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliTestRunner.kt (+3 -2)
📝 pkl-codegen-java/gradle.lockfile (+1 -0)
📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGenerator.kt (+3 -2)
📝 pkl-codegen-kotlin/gradle.lockfile (+1 -0)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGenerator.kt (+3 -2)
📝 pkl-commons-cli/gradle.lockfile (+1 -0)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt (+7 -0)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt (+33 -2)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt (+36 -1)
📝 pkl-commons-cli/src/test/kotlin/org/pkl/commons/cli/BaseCommandTest.kt (+31 -0)
📝 pkl-commons/src/main/kotlin/org/pkl/commons/Strings.kt (+51 -0)

...and 80 more files

📄 Description

SPICE-0009

Includes the changes from https://github.com/apple/pkl/pull/640

Adoption of this feature in language binding libraries:

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/660 **Author:** [@HT154](https://github.com/HT154) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 10/29/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `external-readers` --- ### 📝 Commits (10+) - [`426237a`](https://github.com/apple/pkl/commit/426237a3a01de73e880d81f6ddbb046524e9945a) Refactor message-passing logic into pkl-core - [`dd29012`](https://github.com/apple/pkl/commit/dd290122801a11096793ad1839acd40b5db519ce) Split server-specific messages/encoding/decoding back into pkl-server - [`d27908b`](https://github.com/apple/pkl/commit/d27908bb406e39977a4f5e120120802b1cf8614c) Implement SPICE-0009 External Readers - [`472b89d`](https://github.com/apple/pkl/commit/472b89dfecebab8243825923d8dbd3af042f3e08) docs - [`42ce6f0`](https://github.com/apple/pkl/commit/42ce6f030ba200bfaeee3c4f8b3d08d5fd2ea4ab) Add ExternalReaderRuntime, lots of test coverage - [`4f5a72d`](https://github.com/apple/pkl/commit/4f5a72d93ea7237d31a243cd83274a5eb58992de) Add doc comments to new public APIs - [`b50f801`](https://github.com/apple/pkl/commit/b50f8019d879e62eca94e2d0b3bf6c8f113133c4) Improve backcompat for new language binding libs on old pkl versions - [`b5b6a59`](https://github.com/apple/pkl/commit/b5b6a5967acad0c5c322657a3e83cb14ccc35a82) Apply suggestions from code review - [`ff3f1e0`](https://github.com/apple/pkl/commit/ff3f1e02201ff823bcff70da5e1a951d0bedd72c) Address review feedback - [`d772e5c`](https://github.com/apple/pkl/commit/d772e5c41422b254421a245adeedf2fcfdd41ba4) Use records for message types ### 📊 Changes **110 files changed** (+4363 additions, -1805 deletions) <details> <summary>View changed files</summary> 📝 `bench/gradle.lockfile` (+1 -0) 📝 `docs/gradle.lockfile` (+1 -0) 📝 `docs/modules/bindings-specification/pages/message-passing-api.adoc` (+95 -2) 📝 `docs/modules/language-reference/pages/index.adoc` (+67 -1) 📝 `docs/src/test/kotlin/DocSnippetTests.kt` (+1 -1) 📝 `pkl-cli/gradle.lockfile` (+1 -1) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt` (+3 -2) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliImportAnalyzer.kt` (+3 -2) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliServer.kt` (+2 -3) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliTestRunner.kt` (+3 -2) 📝 `pkl-codegen-java/gradle.lockfile` (+1 -0) 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGenerator.kt` (+3 -2) 📝 `pkl-codegen-kotlin/gradle.lockfile` (+1 -0) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGenerator.kt` (+3 -2) 📝 `pkl-commons-cli/gradle.lockfile` (+1 -0) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt` (+7 -0) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt` (+33 -2) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt` (+36 -1) 📝 `pkl-commons-cli/src/test/kotlin/org/pkl/commons/cli/BaseCommandTest.kt` (+31 -0) 📝 `pkl-commons/src/main/kotlin/org/pkl/commons/Strings.kt` (+51 -0) _...and 80 more files_ </details> ### 📄 Description [SPICE-0009](https://github.com/apple/pkl-evolution/pull/10) Includes the changes from https://github.com/apple/pkl/pull/640 Adoption of this feature in language binding libraries: * https://github.com/apple/pkl-go/pull/101 * https://github.com/apple/pkl-swift/pull/26 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:00 +01:00
adam closed this issue 2025-12-30 01:26:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#661
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?